fix: Update segment compactTo when compactTo segment is compacted #28755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to milvus-io#28736 milvus-io#28748 See also milvus-io#27675 Previous PR: milvus-io#28646 This PR fixes `SegmentNotFound` issue when compaction happens multiple times and the buffer of first generation segment is sync due to stale policy Now the `CompactSegments` API of metacache shall update the compactTo field of segmentInfo if the compactTo segment is also compacted to keep the bloodline clean Also, add the `CompactedSegment` SyncPolicy to sync the compacted segment asap to keep metacache clean Now the `SyncPolicy` is an interface instead of a function type so that when it selects some segments to sync, we colud log the reason and target segment Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
33 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #28755 +/- ##
==========================================
+ Coverage 82.24% 82.26% +0.01%
==========================================
Files 856 856
Lines 119817 119837 +20
==========================================
+ Hits 98539 98578 +39
+ Misses 17971 17956 -15
+ Partials 3307 3303 -4
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #28736 #28748
See also #27675
Previous PR: #28646
This PR fixes
SegmentNotFoundissue when compaction happens multiple times and the buffer of first generation segment is sync due to stale policyNow the
CompactSegmentsAPI of metacache shall update the compactTo field of segmentInfo if the compactTo segment is also compacted to keep the bloodline cleanAlso, add the
CompactedSegmentSyncPolicy to sync the compacted segment asap to keep metacache cleanNow the
SyncPolicyis an interface instead of a function type so that when it selects some segments to sync, we colud log the reason and target segment