Skip to content

Commit

Permalink
enhance: Remove current stats after RollStats action (#30391)
Browse files Browse the repository at this point in the history
See also #27675

BloomFilterSet.current shall be reset after RollStats, otherwise it will
keep tracking whole segment data causing the false positive ratio larger
than expected.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
  • Loading branch information
congqixia authored Jan 31, 2024
1 parent 5cf9bb2 commit b5e078c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions internal/datanode/metacache/bloom_filter_set.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ func (bfs *BloomFilterSet) Roll(newStats ...*storage.PrimaryKeyStats) {
MinPK: stats.MinPk,
}
})...)
bfs.current = nil
}
}

Expand Down

0 comments on commit b5e078c

Please sign in to comment.