Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use writebuffer refactory With level zero delta policy #28336

Closed

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Nov 10, 2023

In addition to the usage of refactory of datanode, This PR changes delta_policy to "l0_policy".

See also: #27675

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/compilation labels Nov 10, 2023
Copy link
Contributor

mergify bot commented Nov 10, 2023

@XuanYang-cn Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Nov 10, 2023

@XuanYang-cn, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

@mergify mergify bot added the needs-rebase label Nov 10, 2023
@XuanYang-cn XuanYang-cn changed the title Use writebuffer refactory Use writebuffer refactory With level zero delta policy Nov 10, 2023
Copy link
Contributor

mergify bot commented Nov 10, 2023

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 10, 2023

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn XuanYang-cn force-pushed the use_writebuffer_refactory branch from a62d086 to b7e27bb Compare November 13, 2023 07:17
Copy link
Contributor

mergify bot commented Nov 13, 2023

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 13, 2023

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn XuanYang-cn force-pushed the use_writebuffer_refactory branch from b7e27bb to ecad920 Compare November 13, 2023 08:47
Copy link
Contributor

mergify bot commented Nov 13, 2023

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn XuanYang-cn force-pushed the use_writebuffer_refactory branch 3 times, most recently from df67682 to ecb6ce4 Compare November 14, 2023 07:15
Copy link
Contributor

mergify bot commented Nov 14, 2023

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn XuanYang-cn force-pushed the use_writebuffer_refactory branch from ecb6ce4 to 6f399a8 Compare November 14, 2023 08:45
Copy link
Contributor

mergify bot commented Nov 14, 2023

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn XuanYang-cn force-pushed the use_writebuffer_refactory branch from 6f399a8 to 6d3d5a4 Compare November 15, 2023 03:01
Copy link
Contributor

mergify bot commented Nov 15, 2023

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn XuanYang-cn force-pushed the use_writebuffer_refactory branch from 6d3d5a4 to 6cdd41c Compare November 15, 2023 07:27
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Nov 15, 2023
@mergify mergify bot removed the needs-rebase label Nov 15, 2023
Copy link
Contributor

mergify bot commented Nov 15, 2023

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines. label Nov 15, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 15, 2023
Copy link
Contributor

mergify bot commented Nov 15, 2023

@XuanYang-cn, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

@mergify mergify bot added the needs-rebase label Nov 15, 2023
Copy link
Contributor

mergify bot commented Nov 15, 2023

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #28336 (a0d643b) into master (cc71393) will decrease coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is 68.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #28336      +/-   ##
==========================================
- Coverage   81.79%   81.77%   -0.02%     
==========================================
  Files         833      842       +9     
  Lines      117654   117684      +30     
==========================================
+ Hits        96235    96237       +2     
- Misses      18188    18212      +24     
- Partials     3231     3235       +4     
Files Coverage Δ
internal/datanode/metacache/segment.go 100.00% <100.00%> (ø)
internal/datanode/syncmgr/meta_writer.go 82.45% <100.00%> (+0.15%) ⬆️
internal/datanode/syncmgr/task.go 80.00% <ø> (-3.92%) ⬇️
internal/datanode/writebuffer/bf_write_buffer.go 85.36% <100.00%> (+0.36%) ⬆️
internal/datanode/writebuffer/sync_policy.go 91.66% <100.00%> (+0.49%) ⬆️
pkg/util/paramtable/component_param.go 98.20% <100.00%> (ø)
internal/datanode/writebuffer/write_buffer.go 88.51% <66.66%> (ø)
internal/datanode/syncmgr/options.go 95.52% <0.00%> (-4.48%) ⬇️
internal/datanode/metacache/actions.go 94.20% <0.00%> (-5.80%) ⬇️
internal/datanode/writebuffer/l0_write_buffer.go 72.30% <70.83%> (+4.12%) ⬆️

... and 166 files with indirect coverage changes

@XuanYang-cn XuanYang-cn force-pushed the use_writebuffer_refactory branch from 494c0db to deb5a4d Compare November 16, 2023 02:41
Copy link
Contributor

mergify bot commented Nov 16, 2023

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 16, 2023

@XuanYang-cn

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • enhance: for improvements to existing functionality.
  • fix: for bug fixes.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, enhance, or fix.

Example:

feat: Enhance search functionality within the user interface

Please review and update your PR to comply with these guidelines.

XuanYang-cn and others added 2 commits November 16, 2023 18:33
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@XuanYang-cn XuanYang-cn force-pushed the use_writebuffer_refactory branch from deb5a4d to a0d643b Compare November 16, 2023 10:33
@XuanYang-cn XuanYang-cn changed the title Use writebuffer refactory With level zero delta policy feat: Use writebuffer refactory With level zero delta policy Nov 16, 2023
@mergify mergify bot added kind/feature Issues related to feature request from users and removed do-not-merge/invalid-pr-format labels Nov 16, 2023
Copy link
Contributor

mergify bot commented Nov 16, 2023

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation dco-passed DCO check passed. kind/feature Issues related to feature request from users needs-rebase size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants