Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel name paramter in FlushSegmentsRequest #27725

Merged

Conversation

congqixia
Copy link
Contributor

This PR add ChannelName parameter in FlushSegmentsRequest
Old datanode will ignore this parameter
New Datanodes with L0 delta may accelerate with this information and also be compatible with request without it
See also #27675

/kind improvement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 16, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XL Denotes a PR that changes 500-999 lines. labels Oct 16, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #27725 (f22bf6e) into master (43f2452) will increase coverage by 0.10%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27725      +/-   ##
==========================================
+ Coverage   81.52%   81.62%   +0.10%     
==========================================
  Files         806      807       +1     
  Lines      114267   114581     +314     
==========================================
+ Hits        93153    93525     +372     
+ Misses      17978    17909      -69     
- Partials     3136     3147      +11     
Files Coverage Δ
internal/datacoord/cluster.go 92.00% <100.00%> (+0.10%) ⬆️

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Oct 17, 2023
@yah01
Copy link
Member

yah01 commented Oct 17, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit b7bfcca into milvus-io:master Oct 17, 2023
12 checks passed
@congqixia congqixia deleted the flush_segments_with_channel branch October 17, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants