Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add l0 metric and fix datacoord no need drop l0 segment when flush #28373

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Nov 13, 2023

relate: #27675

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 13, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Nov 13, 2023
Copy link
Contributor

mergify bot commented Nov 13, 2023

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 13, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 13, 2023

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 16, 2023

@aoiasd

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • enhance: for improvements to existing functionality.
  • fix: for bug fixes.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, enhance, or fix.

Example:

feat: Enhance search functionality within the user interface

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Nov 20, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd aoiasd changed the title Add l0 metric and fix datacoord no need drop l0 segment when flush enhance: add l0 metric and fix datacoord no need drop l0 segment when flush Nov 20, 2023
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Nov 20, 2023
Copy link
Contributor

mergify bot commented Nov 20, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 20, 2023

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 20, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #28373 (4c18652) into master (7f46f4c) will increase coverage by 0.02%.
Report is 43 commits behind head on master.
The diff coverage is 90.90%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #28373      +/-   ##
==========================================
+ Coverage   81.86%   81.88%   +0.02%     
==========================================
  Files         843      843              
  Lines      117770   117803      +33     
==========================================
+ Hits        96412    96463      +51     
+ Misses      18126    18111      -15     
+ Partials     3232     3229       -3     
Files Coverage Δ
internal/datacoord/meta.go 87.19% <100.00%> (+0.03%) ⬆️
internal/datacoord/util.go 99.25% <100.00%> (+0.04%) ⬆️
pkg/metrics/datacoord_metrics.go 100.00% <100.00%> (ø)
pkg/metrics/metrics.go 100.00% <ø> (ø)
internal/datacoord/services.go 84.14% <50.00%> (-0.25%) ⬇️

... and 27 files with indirect coverage changes

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 21, 2023
Copy link
Contributor

mergify bot commented Nov 21, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 21, 2023

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 21, 2023
pkg/metrics/datacoord_metrics.go Show resolved Hide resolved
pkg/metrics/datacoord_metrics.go Show resolved Hide resolved
@XuanYang-cn
Copy link
Contributor

/lgtm

Copy link
Contributor

mergify bot commented Nov 23, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 23, 2023

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 23, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 23, 2023

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 23, 2023
@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8a4cfb7 into milvus-io:master Nov 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants