Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use RWMutex and change WLock to RLock #30557

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

congqixia
Copy link
Contributor

Related to #27675

Related to milvus-io#27675

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98adbb3) 80.23% compared to head (33e329b) 80.23%.
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30557      +/-   ##
==========================================
- Coverage   80.23%   80.23%   -0.01%     
==========================================
  Files         965      965              
  Lines      136070   136070              
==========================================
- Hits       109180   109177       -3     
  Misses      23171    23171              
- Partials     3719     3722       +3     
Files Coverage Δ
internal/datanode/metacache/bloom_filter_set.go 92.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 6, 2024
@congqixia
Copy link
Contributor Author

/approve

@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b111f3b into milvus-io:master Feb 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants