enhance: Make write buffer memory check do until safe #32172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
@congqixia ut workflow job failed, comment |
See also milvus-io#27675 milvus-io#26177 Make memory check evict memory buffer until memory water level is safe. Also make `EvictBuffer` wait until sync task done. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
force-pushed
the
enhance/evict_until_safe
branch
from
a5afa91 to
7077862
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32172 +/- ##
==========================================
- Coverage 81.75% 81.70% -0.05%
==========================================
Files 991 991
Lines 122131 122134 +3
==========================================
- Hits 99853 99795 -58
- Misses 18452 18512 +60
- Partials 3826 3827 +1
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Apr 12, 2024
See also milvus-io#27675 milvus-io#26177 Make memory check evict memory buffer until memory water level is safe. Also make `EvictBuffer` wait until sync task done. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #27675 #26177
Make memory check evict memory buffer until memory water level is safe. Also make
EvictBufferwait until sync task done.