-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Remove commented code and fix naming issue #28450
enhance: Remove commented code and fix naming issue #28450
Conversation
This PR removes all the commented code and files from PR milvus-io#28320 For naming issue: - Renaming `MinCheckpoint` to `EarliestPosition`, see milvus-io#28320 comment - Renaming `writebuffer.Mananger` to `BufferMananger`, see milvus-io#27874 comment Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind improvement |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
1 similar comment
/run-cpu-e2e |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #28450 +/- ##
==========================================
+ Coverage 81.71% 81.75% +0.04%
==========================================
Files 842 842
Lines 117701 117702 +1
==========================================
+ Hits 96176 96230 +54
+ Misses 18289 18246 -43
+ Partials 3236 3226 -10
|
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
1 similar comment
/run-cpu-e2e |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
/lgtm |
This PR removes all the commented code and files from PR #28320
For naming issue:
MinCheckpoint
toEarliestPosition
, see Use writebuffer, sync manager refactory in datanode #28320 commentwritebuffer.Mananger
toBufferMananger
, see AddWriteBuffer
to provided absbraction for delta policy #27874 comment