Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove commented code and fix naming issue #28450

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

congqixia
Copy link
Contributor

This PR removes all the commented code and files from PR #28320

For naming issue:

This PR removes all the commented code and files from PR milvus-io#28320

For naming issue:
- Renaming `MinCheckpoint` to `EarliestPosition`, see milvus-io#28320 comment
- Renaming `writebuffer.Mananger` to `BufferMananger`, see milvus-io#27874
  comment

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia
Copy link
Contributor Author

/kind improvement

@sre-ci-robot sre-ci-robot added approved kind/improvement Changes related to something improve, likes ut and code refactor size/XL Denotes a PR that changes 500-999 lines. labels Nov 15, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Nov 15, 2023
Copy link
Contributor

mergify bot commented Nov 15, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #28450 (0c7d802) into master (0b90507) will increase coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #28450      +/-   ##
==========================================
+ Coverage   81.71%   81.75%   +0.04%     
==========================================
  Files         842      842              
  Lines      117701   117702       +1     
==========================================
+ Hits        96176    96230      +54     
+ Misses      18289    18246      -43     
+ Partials     3236     3226      -10     
Files Coverage Δ
internal/datanode/compactor.go 86.21% <100.00%> (ø)
internal/datanode/data_node.go 75.96% <ø> (ø)
internal/datanode/data_sync_service.go 76.19% <ø> (ø)
internal/datanode/flow_graph_time_tick_node.go 84.53% <100.00%> (ø)
internal/datanode/flow_graph_write_node.go 83.95% <ø> (ø)
internal/datanode/syncmgr/sync_manager.go 92.10% <100.00%> (ø)
internal/datanode/writebuffer/bf_write_buffer.go 85.00% <100.00%> (ø)
internal/datanode/writebuffer/l0_write_buffer.go 68.18% <100.00%> (ø)
internal/datanode/writebuffer/manager.go 84.15% <100.00%> (ø)
internal/datanode/writebuffer/segment_buffer.go 83.33% <100.00%> (ø)
... and 1 more

... and 15 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 15, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 15, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 15, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 15, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 15, 2023
@XuanYang-cn
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit bed7467 into milvus-io:master Nov 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants