enhance: reduce SyncTask AllocID call and refine code #29701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also milvus-io#27675 `Allocator.Alloc` and `Allocator.AllocOne` might be invoked multiple times if there were multiple blobs set in one sync task. This PR add pre-fetch logic for all blobs and cache logIDs in sync task so that at most only one call of the allocator is needed. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
mergify
bot
added
dco-passed
33 tasks
|
@congqixia ut workflow job failed, comment |
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29701 +/- ##
==========================================
- Coverage 83.72% 80.80% -2.93%
==========================================
Files 679 922 +243
Lines 108623 127406 +18783
==========================================
+ Hits 90949 102948 +11999
- Misses 14361 21149 +6788
+ Partials 3313 3309 -4
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #27675
Allocator.AllocandAllocator.AllocOnemight be invoked multiple times if there were multiple blobs set in one sync task.This PR add pre-fetch logic for all blobs and cache logIDs in sync task so that at most only one call of the allocator is needed.