enhance: Log channel checkpoint source info in writebuffer #28993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
33 tasks
See also milvus-io#27675 Print channel checkpoint source with rated log will help debugging system behavior Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
force-pushed
the
log_checkpoint_source
branch
from
192692a to
b882b2a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #28993 +/- ##
==========================================
- Coverage 82.02% 82.00% -0.02%
==========================================
Files 862 862
Lines 121748 121788 +40
==========================================
+ Hits 99865 99874 +9
- Misses 18565 18591 +26
- Partials 3318 3323 +5
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #27675
Print channel checkpoint source with rated log will help debugging system behavior