Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust datacoord for L0 Delta #28021

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Adjust datacoord for L0 Delta #28021

merged 1 commit into from
Nov 6, 2023

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Oct 30, 2023

relate: #27675

@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Oct 30, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2023

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2023

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2023

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@aoiasd aoiasd changed the title Refactor datacoord for L0 Delta Adjust datacoord for L0 Delta Nov 1, 2023
@aoiasd aoiasd force-pushed the C3 branch 2 times, most recently from c3f41ea to 03ccf06 Compare November 1, 2023 11:32
Copy link
Contributor

mergify bot commented Nov 1, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 2, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #28021 (5975d37) into master (ab6dbf7) will decrease coverage by 0.03%.
Report is 24 commits behind head on master.
The diff coverage is 80.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #28021      +/-   ##
==========================================
- Coverage   81.81%   81.78%   -0.03%     
==========================================
  Files         820      834      +14     
  Lines      116929   118016    +1087     
==========================================
+ Hits        95663    96519     +856     
- Misses      18097    18305     +208     
- Partials     3169     3192      +23     
Files Coverage Δ
internal/datacoord/segment_allocation_policy.go 90.62% <100.00%> (-0.29%) ⬇️
internal/datacoord/segment_manager.go 88.54% <100.00%> (-1.23%) ⬇️
internal/datacoord/util.go 99.19% <100.00%> (+0.11%) ⬆️
internal/metastore/kv/datacoord/kv_catalog.go 76.47% <100.00%> (-1.74%) ⬇️
internal/datacoord/services.go 84.36% <97.36%> (-0.44%) ⬇️
internal/datacoord/meta.go 87.23% <78.70%> (-0.94%) ⬇️
internal/metastore/kv/datacoord/util.go 75.47% <75.47%> (ø)

... and 193 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 2, 2023
@XuanYang-cn
Copy link
Contributor

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1d4be0d into milvus-io:master Nov 6, 2023
12 checks passed
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Apr 24, 2024
@mergify mergify bot removed the dco-passed DCO check passed. label Apr 24, 2024
Copy link
Contributor

mergify bot commented Apr 24, 2024

@aoiasd Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

Copy link
Contributor

mergify bot commented Apr 24, 2024

@aoiasd

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@mergify mergify bot removed the ci-passed label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api do-not-merge/invalid-pr-format lgtm needs-dco DCO is missing in this pull request. size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants