v5.52.0 proposal #5684
Draft
v5.52.0 proposal #5684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dd-trace-js[bot]](https://avatars.githubusercontent.com/u/1596303?s=60&v=4){kind=small}
Due to a bug in how the tracer configuration was parsed, older versions of the
tracer would always have Code Origin for entry spans enabled, no matter if it
was disabled in config (which it was supposed to be by default). This bug only
applied to Code Origin for entry spans on Fastify, whereas Code Origin for exit
spans correctly adhered to the config.
This bug has been precent in the tracer since Code Origin for Spans was added
in v5.24.0 on October 17th 2024 and there has not been any reports of issues
related to this. Based on that, Code Origin for Spans will now be enabled by
default. The main functional difference with this commit, is that the feature
can now actually be turned off using the config.
Code Origin for exit spans are still experimental:
Since Code Origin for exit spans was never affected by this bug, we have
decided to leave this feature as opt-in, which means it's going to be off by
default. A new experimental config option has been introduced to allow users to
enable/disable Code Origin for exit spans independently, either via an
environment variable:
DD_CODE_ORIGIN_FOR_SPANS_EXPERIMENTAL_EXIT_SPANS_ENABLED=true
Or via inline config:
tracer.init({
codeOriginForSpans: {
experimental: {
exit_spans: { enabled: true }
}
}
})
The logger instrumentation is using a proxy. Calling Reflect.get with a receiver might actually cause issues at times. Instead, just access the target directly. That is easier and safer in this situation. On top, remove the special handling for Symbol.toStringTag. That was added for the testing library and should not have been there in the first place. As a drive-by fix, it also improves the performance a very tiny bit.
* remove dotenv package * remove other unused packages * remove mkdirp
…5679) * pass path separately for request options * remove comment
* add support for pg cursors / streams
Closed
Overall package sizeSelf size: 9.36 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5.x #5684 +/- ##
=======================================
Coverage ? 78.96%
=======================================
Files ? 514
Lines ? 23455
Branches ? 0
=======================================
Hits ? 18522
Misses ? 4933
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 935 Passed, 0 Skipped, 15m 41.98s Total Time |
BenchmarksBenchmark execution time: 2025-05-13 05:19:58 Comparing candidate commit 548323a in PR branch Found 18 performance improvements and 0 performance regressions! Performance is the same for 1251 metrics, 54 unstable metrics. scenario:appsec-iast-startup-time-iast-enabled-20
scenario:appsec-iast-startup-time-iast-enabled-22
scenario:net-with-tracer-20
scenario:plugin-dns-with-tracer-18
scenario:plugin-dns-with-tracer-20
scenario:plugin-dns-with-tracer-22
scenario:runtime-metrics-with-runtime-metrics-20
scenario:runtime-metrics-with-runtime-metrics-22
|
* fix(vitest): fix coverage not being reported when value is zero * Add zero coverage test case As drive-by improve the test to use async/await. --------- Co-authored-by: Giamir Buoncristiani <giamir.buoncristiani@gmail.com>
Otherwise remote config's futile attempts to connect to agent time out tests.
* remove async resource usage from net integration * remove async resource usage from dns integration * code cleanup * fix fs and profiling
…5683) * Refactor docker code for simplicity --------- Co-authored-by: Andre Caron <andre.l.caron@gmail.com>
dd-trace-js
bot
force-pushed
the
v5.52.0-proposal
branch
from
0389d60 to
3be9b88
Compare
|
I fear the aws-sdk changes might be a regression. It does show up more frequently for v18 with the latest fixes for v24. |
* manual keep trace on asm standalone and api security * set priority to user reject from auto * add test for sample request * keep auto reject
dd-trace-js
bot
force-pushed
the
v5.52.0-proposal
branch
from
3be9b88 to
118b696
Compare
dd-trace-js
bot
force-pushed
the
v5.52.0-proposal
branch
from
118b696 to
c2cad35
Compare
Before the first probe is added, the Chrome DevTools Protocol (CDP) sesion is started and after the last probe has been deleted/deactivated, the CDP session is stopped. When these events happen, log a debug message.
dd-trace-js
bot
force-pushed
the
v5.52.0-proposal
branch
from
c2cad35 to
548323a
Compare
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Test Optimization ReportBranch report: ✅ 0 Failed, 561 Passed, 0 Skipped, 1m 49.17s Total Time Was this helpful? Give us feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f4ee8443bf] - (SEMVER-PATCH) use no async context frame option for now (Bryan English) #57069702e5bb23] - (SEMVER-MINOR) Bump taint tracking package (Carles Capell) #57018ca6920ff2] - (SEMVER-PATCH) Skip app-dir app in nextjs 13.2 test in node 24 (Skip app-dir app in nextjs 13.2 test in node 24 #5691) (Ugaitz Urien) #5699ed02dd9d75] - (SEMVER-PATCH) [DI] Add debug logs when starting/stopping the CDP session (Thomas Watson) #56946e4b4641b8] - (SEMVER-MINOR) [test-optimization] [SDTEST-1983] Add commit sha to request of Test Management (Mario Vidal Domínguez) #56882c5fb90f5c] - (SEMVER-PATCH) [DI] Slight improvement to script-matching algorithm (Thomas Watson) #56955e899cb114] - (SEMVER-PATCH) re-enable release proposal dont-land-on checks (Roch Devost) #56653e3d7d6ded] - (SEMVER-MINOR) Update pprof-nodejs to 5.8.0 (Nicolas Savoire) #5693f13861a1f3] - (SEMVER-MINOR) tracing: add support for @confluentinc/kafka-javascript (William Conti) #5489d6df5c1606] - (SEMVER-PATCH) manual keep trace on asm standalone and api security (Ilyas Shabi) #5649f3cf426fd1] - (SEMVER-PATCH) [DI] Fix tests in Node.js 24 (Thomas Watson) #5689052bdaae4a] - (SEMVER-PATCH) Fix Node 24 warning for invoking fs.existsSync with invalid argument type (Attila Szegedi) #56878d6b823ffe] - (SEMVER-PATCH) fix: Support for inode when /proc/self/cgroup is a multiline string (Ruben Bridgewater) #5683edde8b566b] - (SEMVER-PATCH) remove async resource usage from dns/fs/net integrations (Roch Devost) #567356b04d0140] - (SEMVER-PATCH) Add a fake agent for code hotspots and timeline tests too. (Attila Szegedi) #5667c2f57b8ce0] - (SEMVER-PATCH) fix(vitest): fix coverage not being reported when value is zero (Ruben Bridgewater) #56813e85c09fb4] - (SEMVER-PATCH) fix rasp ssrf flaky test (Ilyas Shabi) #5659f2b167d343] - (SEMVER-MINOR) tracing: add support for pg cursors / streams (William Conti) #5680daf4277f3e] - (SEMVER-PATCH) fix(llmobs): llmobs data can be sent to agent proxy running on uds (Sam Brenner) #56794031dd25ea] - (SEMVER-PATCH) Remove unused dev dependencies (Ilyas Shabi) #5668c8a06cd9b9] - (SEMVER-PATCH) Improve log safety (Ruben Bridgewater) #5631c0d30aeafe] - (SEMVER-MINOR) Upgradeattempt_to_fixtov3(Mario Vidal Domínguez) #5670f9b709b11b] - (SEMVER-PATCH) Revert "node action default version" (Roch Devost) #56759721d0895f] - (SEMVER-PATCH) switch to default github token for ci visibility benchmark (Roch Devost) #5639b1727dd9bf] - (SEMVER-PATCH) [Code Origin for Spans] Allow code origin to be disabled (Thomas Watson) #563554c86664a9] - (SEMVER-PATCH) use a fixed version for latest in node action (Roch Devost) #5671108c0b4fba] - (SEMVER-PATCH) fix release proposal not closing patch pr on minor (Roch Devost) #5663