Skip to content

remove async resource usage from dns/fs/net integrations #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented May 6, 2025

What does this PR do?

Remove AsyncResource usage from dns, fs and net integrations.

Motivation

Using AsyncResource for this is incorrect as it will change the underlying resource for all stores and not just ours. There is also a bug in Node 24 when using AsyncResource that isn't triggered when using runStores instead.

Copy link

github-actions bot commented May 6, 2025

Overall package size

Self size: 9.31 MB
Deduped: 102.55 MB
No deduping: 103.07 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 3.3.1 | 13.99 MB | 13.99 MB | | @datadog/pprof | 5.7.1 | 9.51 MB | 9.88 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 46.23656% with 50 lines in your changes missing coverage. Please review.

Project coverage is 79.09%. Comparing base (9721d08) to head (90801fa).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
packages/datadog-instrumentations/src/net.js 10.00% 18 Missing ⚠️
packages/datadog-instrumentations/src/dns.js 7.14% 13 Missing ⚠️
...ace/src/profiling/profilers/event_plugins/event.js 11.11% 8 Missing ⚠️
packages/datadog-instrumentations/src/fs.js 81.81% 6 Missing ⚠️
...c/profiling/profilers/event_plugins/dns_resolve.js 0.00% 2 Missing ⚠️
...rc/profiling/profilers/event_plugins/dns_lookup.js 0.00% 1 Missing ⚠️
...iling/profilers/event_plugins/dns_lookupservice.js 0.00% 1 Missing ⚠️
...c/profiling/profilers/event_plugins/dns_reverse.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5673      +/-   ##
==========================================
- Coverage   79.13%   79.09%   -0.04%     
==========================================
  Files         513      513              
  Lines       23500    23530      +30     
==========================================
+ Hits        18596    18611      +15     
- Misses       4904     4919      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented May 6, 2025

Benchmarks

Benchmark execution time: 2025-05-08 02:26:19

Comparing candidate commit 90801fa in PR branch remove-net-dns-async-resource with baseline commit 9721d08 in branch master.

Found 16 performance improvements and 0 performance regressions! Performance is the same for 1255 metrics, 52 unstable metrics.

scenario:appsec-iast-startup-time-iast-enabled-22

  • 🟩 cpu_user_time [-121.491ms; -89.634ms] or [-7.237%; -5.339%]
  • 🟩 execution_time [-132.862ms; -107.419ms] or [-6.662%; -5.386%]

scenario:plugin-dns-with-tracer-18

  • 🟩 cpu_user_time [-59.942ms; -33.677ms] or [-10.422%; -5.855%]

scenario:plugin-dns-with-tracer-20

  • 🟩 cpu_user_time [-99.701ms; -77.496ms] or [-17.127%; -13.312%]
  • 🟩 instructions [-184.7M instructions; -175.9M instructions] or [-16.067%; -15.300%]
  • 🟩 max_rss_usage [-9.405MB; -9.114MB] or [-11.820%; -11.454%]

scenario:plugin-dns-with-tracer-22

  • 🟩 cpu_user_time [-100.089ms; -78.056ms] or [-19.082%; -14.881%]
  • 🟩 instructions [-188.8M instructions; -180.1M instructions] or [-15.236%; -14.530%]
  • 🟩 max_rss_usage [-11.703MB; -11.480MB] or [-13.616%; -13.357%]

scenario:runtime-metrics-with-runtime-metrics-20

  • 🟩 cpu_user_time [-68.124ms; -42.916ms] or [-14.504%; -9.137%]
  • 🟩 instructions [-140.2M instructions; -113.1M instructions] or [-13.173%; -10.624%]
  • 🟩 max_rss_usage [-8.046MB; -6.154MB] or [-10.309%; -7.884%]

scenario:runtime-metrics-with-runtime-metrics-22

  • 🟩 cpu_usage_percentage [-6.544%; -5.117%]
  • 🟩 cpu_user_time [-80.233ms; -54.220ms] or [-18.544%; -12.531%]
  • 🟩 instructions [-169.6M instructions; -154.6M instructions] or [-14.022%; -12.779%]
  • 🟩 max_rss_usage [-13.240MB; -12.434MB] or [-15.108%; -14.187%]

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 6, 2025

Datadog Report

Branch report: remove-net-dns-async-resource
Commit report: cb2b241
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 935 Passed, 0 Skipped, 15m 34.33s Total Time

@rochdev rochdev marked this pull request as ready for review May 6, 2025 23:14
@rochdev rochdev requested review from a team as code owners May 6, 2025 23:14
@rochdev rochdev changed the title remove async resource usage from net integration remove async resource usage from dns and net integrations May 6, 2025
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great!

Just two profiler tests are still failing and it still needs some additional tests to cover the current changed code :)

@bengl
Copy link
Collaborator

bengl commented May 7, 2025

I'm going to pull this into feature/node-24 and make sure it passed on Node.js 24.

EDIT: The net and dns tests pass on that branch after pulling in these commits. Once This PR lands, I'll remove them from the feature/node-24 branch.

@rochdev
Copy link
Member Author

rochdev commented May 7, 2025

Just two profiler tests are still failing and it still needs some additional tests to cover the current changed code :)

This fixes an issue in Node 24. It will become tested once we enable the tests for Node 24. Meanwhile, @bengl has validated above that it fixes the issue.

@rochdev rochdev changed the title remove async resource usage from dns and net integrations remove async resource usage from dns/fs/net integrations May 8, 2025
@bengl bengl merged commit edde8b5 into master May 8, 2025
440 checks passed
@bengl bengl deleted the remove-net-dns-async-resource branch May 8, 2025 15:17
dd-trace-js bot pushed a commit that referenced this pull request May 8, 2025
* remove async resource usage from net integration

* remove async resource usage from dns integration

* code cleanup

* fix fs and profiling
@dd-trace-js dd-trace-js bot mentioned this pull request May 8, 2025
bengl pushed a commit that referenced this pull request May 13, 2025
* remove async resource usage from net integration

* remove async resource usage from dns integration

* code cleanup

* fix fs and profiling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants