Skip to content

[DI] Add debug logs when starting/stopping the CDP session - #5694

Merged
BridgeAR merged 1 commit into
masterfrom
watson/DEBUG-3843/add-extra-debug-logs
May 12, 2025
Merged

[DI] Add debug logs when starting/stopping the CDP session#5694
BridgeAR merged 1 commit into
masterfrom
watson/DEBUG-3843/add-extra-debug-logs

Conversation

@watson

@watson watson commented May 12, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

Before the first probe is added, the Chrome DevTools Protocol (CDP) sesion is started and after the last probe has been deleted/deactivated, the CDP session is stopped.

When these events happen, log a debug message.

Motivation

Improve debugging abilities when something is not working as expected.

Plugin Checklist

Additional Notes

Before the first probe is added, the Chrome DevTools Protocol (CDP)
sesion is started and after the last probe has been deleted/deactivated,
the CDP session is stopped.

When these events happen, log a debug message.
@watson
watson requested review from a team as code owners May 12, 2025 04:55
@watson watson self-assigned this May 12, 2025

watson commented May 12, 2025

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson added semver-patch debugger Dynamic Instrumentation & Live Debugger labels May 12, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 9.36 MB
Deduped: 105.65 MB
No deduping: 106.17 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 3.3.1 | 13.99 MB | 13.99 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented May 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (5e899cb) to head (eb983d0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5694      +/-   ##
==========================================
- Coverage   79.06%   78.99%   -0.07%     
==========================================
  Files         514      513       -1     
  Lines       23548    23476      -72     
==========================================
- Hits        18618    18545      -73     
- Misses       4930     4931       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1

Copy link
Copy Markdown

Datadog Report

Branch report: watson/DEBUG-3843/add-extra-debug-logs
Commit report: c1cafad
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 931 Passed, 0 Skipped, 14m 23.58s Total Time

@pr-commenter

pr-commenter Bot commented May 12, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-12 05:08:07

Comparing candidate commit eb983d0 in PR branch watson/DEBUG-3843/add-extra-debug-logs with baseline commit 5e899cb in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1274 metrics, 49 unstable metrics.

@BridgeAR
BridgeAR merged commit ed02dd9 into master May 12, 2025
@BridgeAR
BridgeAR deleted the watson/DEBUG-3843/add-extra-debug-logs branch May 12, 2025 11:10
ghost pushed a commit that referenced this pull request May 13, 2025
Before the first probe is added, the Chrome DevTools Protocol (CDP)
sesion is started and after the last probe has been deleted/deactivated,
the CDP session is stopped.

When these events happen, log a debug message.
@ghost ghost mentioned this pull request May 13, 2025
bengl pushed a commit that referenced this pull request May 13, 2025
Before the first probe is added, the Chrome DevTools Protocol (CDP)
sesion is started and after the last probe has been deleted/deactivated,
the CDP session is stopped.

When these events happen, log a debug message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debugger Dynamic Instrumentation & Live Debugger semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants