Skip to content

use no async context frame option for now #5706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented May 12, 2025

What does this PR do?

Adds --no-async-context-frame on tests whenever child processes are used. This mainly applies to integration tests.

The debugger test is also affected, but since it's been updated to work with AsyncContextFrame, there's an override option for that one.

This makes all integration tests pass on Node.js 24, since the flag reverts to Node.js <24 behaviour.

Additional Notes

We'll back all of this out once we can fully support Node.js 24 and not use the flag.

@bengl bengl requested a review from a team as a code owner May 12, 2025 20:18
Copy link

Overall package size

Self size: 9.36 MB
Deduped: 103.38 MB
No deduping: 103.9 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.05%. Comparing base (9702e5b) to head (7ae2b70).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5706      +/-   ##
==========================================
+ Coverage   78.99%   79.05%   +0.06%     
==========================================
  Files         513      514       +1     
  Lines       23476    23548      +72     
==========================================
+ Hits        18545    18617      +72     
  Misses       4931     4931              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bengl bengl merged commit f4ee844 into master May 12, 2025
486 of 488 checks passed
@bengl bengl deleted the bengl/no-acf-for-now branch May 12, 2025 20:46
@dd-trace-js dd-trace-js bot mentioned this pull request May 13, 2025
childProcess.fork = function (...args) {
const opts = args[1]
if (opts) {
if (opts?.env?.NODE_OPTIONS && !opts.env.NODE_OPTIONS.includes('--no-async-context-frame')) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the second condition should actually be an inner if and it would just skip the addition. Otherwise the presence of the flag would remove all other NODE_OPTIONS potentially also being set.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right. While this is only in test code where we control NODE_OPTIONS, we don't necessarily know where we might want to add other things, so this is worth fixing. I'll do that in a follow-up PR in a few min. 👍

bengl added a commit that referenced this pull request May 13, 2025
szegedi added a commit that referenced this pull request May 16, 2025
szegedi added a commit that referenced this pull request May 16, 2025
szegedi added a commit that referenced this pull request Jun 4, 2025
szegedi added a commit that referenced this pull request Jun 11, 2025
szegedi added a commit that referenced this pull request Jun 25, 2025
szegedi added a commit that referenced this pull request Jun 26, 2025
szegedi added a commit that referenced this pull request Jun 30, 2025
szegedi added a commit that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants