Fix Node 24 warning for invoking fs.existsSync with invalid argument type (#5687)

szegedi · web-flow · commit 052bdaae4ae1 · 2025-05-09T11:51:36.000+02:00
diff --git a/packages/dd-trace/src/guardrails/telemetry.js b/packages/dd-trace/src/guardrails/telemetry.js
@@ -14,11 +14,8 @@ if (!process.env.DD_INJECTION_ENABLED) {
   module.exports = function () {}
 }
 
-if (!process.env.DD_TELEMETRY_FORWARDER_PATH) {
-  module.exports = function () {}
-}
-
-if (!fs.existsSync(process.env.DD_TELEMETRY_FORWARDER_PATH)) {
+var telemetryForwarderPath = process.env.DD_TELEMETRY_FORWARDER_PATH
+if (typeof telemetryForwarderPath !== 'string' || !fs.existsSync(telemetryForwarderPath)) {
   module.exports = function () {}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -14,11 +14,8 @@ if (!process.env.DD_INJECTION_ENABLED) {`
`14`	`14`	`module.exports = function () {}`
`15`	`15`	`}`
`16`	`16`
`17`		`-if (!process.env.DD_TELEMETRY_FORWARDER_PATH) {`
`18`		`- module.exports = function () {}`
`19`		`-}`
`20`		`-`
`21`		`-if (!fs.existsSync(process.env.DD_TELEMETRY_FORWARDER_PATH)) {`
	`17`	`+var telemetryForwarderPath = process.env.DD_TELEMETRY_FORWARDER_PATH`
	`18`	`+if (typeof telemetryForwarderPath !== 'string' \|\| !fs.existsSync(telemetryForwarderPath)) {`
`22`	`19`	`module.exports = function () {}`
`23`	`20`	`}`
`24`	`21`