Skip to content

fix(vitest): fix coverage not being reported when value is zero #5681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

BridgeAR
Copy link
Collaborator

@BridgeAR BridgeAR commented May 8, 2025

Supersedes #5395

@BridgeAR BridgeAR requested a review from a team as a code owner May 8, 2025 01:29
@BridgeAR BridgeAR requested a review from Mariovido May 8, 2025 01:29
Copy link

github-actions bot commented May 8, 2025

Overall package size

Self size: 9.31 MB
Deduped: 102.56 MB
No deduping: 103.08 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 3.3.1 | 13.99 MB | 13.99 MB | | @datadog/pprof | 5.7.1 | 9.51 MB | 9.88 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (3e85c09) to head (992993f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5681      +/-   ##
==========================================
- Coverage   79.11%   79.04%   -0.07%     
==========================================
  Files         513      512       -1     
  Lines       23521    23449      -72     
==========================================
- Hits        18608    18536      -72     
  Misses       4913     4913              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 8, 2025

Datadog Report

Branch report: BridgeAR/port-vitest-fix
Commit report: 2ac48ba
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 926 Passed, 0 Skipped, 11m 43.34s Total Time

@pr-commenter
Copy link

pr-commenter bot commented May 8, 2025

Benchmarks

Benchmark execution time: 2025-05-08 02:10:07

Comparing candidate commit 992993f in PR branch BridgeAR/port-vitest-fix with baseline commit 3e85c09 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1273 metrics, 50 unstable metrics.

As drive-by improve the test to use async/await.
@BridgeAR BridgeAR force-pushed the BridgeAR/port-vitest-fix branch from c8af587 to 992993f Compare May 8, 2025 01:57
@BridgeAR BridgeAR merged commit c2f57b8 into master May 8, 2025
440 of 441 checks passed
@BridgeAR BridgeAR deleted the BridgeAR/port-vitest-fix branch May 8, 2025 11:57
dd-trace-js bot pushed a commit that referenced this pull request May 8, 2025
* fix(vitest): fix coverage not being reported when value is zero

* Add zero coverage test case

As drive-by improve the test to use async/await.

---------

Co-authored-by: Giamir Buoncristiani <giamir.buoncristiani@gmail.com>
@dd-trace-js dd-trace-js bot mentioned this pull request May 8, 2025
bengl pushed a commit that referenced this pull request May 13, 2025
* fix(vitest): fix coverage not being reported when value is zero

* Add zero coverage test case

As drive-by improve the test to use async/await.

---------

Co-authored-by: Giamir Buoncristiani <giamir.buoncristiani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants