Skip to content

Commit 8ca6920

Browse files
uurienBridgeAR
andauthored
Skip app-dir app in nextjs 13.2 test in node 24 (#5691) (#5699)
* Skip app-dir app in nextjs 13.2 test in node 24 * Ignore >=11.0.0 <13 in node 24.0.0 * Update packages/dd-trace/test/appsec/index.next.plugin.spec.js --------- Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
1 parent ed02dd9 commit 8ca6920

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

packages/dd-trace/test/appsec/index.next.plugin.spec.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ const { satisfies } = require('semver')
99
const path = require('path')
1010

1111
const agent = require('../plugins/agent')
12+
const { NODE_MAJOR, NODE_MINOR, NODE_PATCH } = require('../../../../version')
1213

1314
describe('test suite', () => {
1415
let server
@@ -17,6 +18,11 @@ describe('test suite', () => {
1718
const satisfiesStandalone = version => satisfies(version, '>=12.0.0')
1819

1920
withVersions('next', 'next', '>=11.1', version => {
21+
if (version === '>=11.0.0 <13' && NODE_MAJOR === 24 &&
22+
NODE_MINOR === 0 && NODE_PATCH === 0) {
23+
return // node 24.0.0 fails, but 24.0.1 works
24+
}
25+
2026
const realVersion = require(`../../../../versions/next@${version}`).version()
2127

2228
function initApp (appName) {
@@ -146,7 +152,7 @@ describe('test suite', () => {
146152
}
147153
]
148154

149-
if (satisfies(realVersion, '>=13.2')) {
155+
if (satisfies(realVersion, '>=13.2') && (NODE_MAJOR < 24 || satisfies(realVersion, '!=13.2'))) {
150156
tests.push({
151157
appName: 'app-dir',
152158
serverPath: '.next/standalone/server.js'

0 commit comments

Comments
 (0)