Skip to content

Commit f3cb875

Browse files
benglBridgeAR
andauthored
Node.js 24 support (#5678)
* Revert "use a fixed version for latest in node action (#5671)" This reverts commit 54c8666. * Update .github/actions/node/action.yml * don't use AsyncContextFrame in aws-sdk tests for now --------- Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
1 parent af5717e commit f3cb875

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.github/actions/node/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ runs:
1010
steps:
1111
- uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4.3.0
1212
with:
13-
node-version: ${{ inputs.version == 'eol' && '16' || inputs.version == 'oldest' && '18' || inputs.version == 'maintenance' && '20' || inputs.version == 'active' && '22' || inputs.version == 'latest' && '23' || inputs.version }}
13+
node-version: ${{ inputs.version == 'eol' && '16' || inputs.version == 'oldest' && '18' || inputs.version == 'maintenance' && '20' || inputs.version == 'active' && '22' || inputs.version == 'latest' && '24' || inputs.version }}
1414
check-latest: true
1515
registry-url: ${{ inputs.registry-url || 'https://registry.npmjs.org' }}

.github/workflows/plugins.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,11 @@ jobs:
124124
aws-sdk:
125125
strategy:
126126
matrix:
127-
node-version: [oldest, 'latest']
127+
include:
128+
- node-version: latest
129+
node-opts: --no-async-context-frame
130+
- node-version: oldest
131+
node-opts: ''
128132
runs-on: ubuntu-latest
129133
services:
130134
localstack:
@@ -168,6 +172,8 @@ jobs:
168172
version: ${{ matrix.node-version }}
169173
- uses: ./.github/actions/install
170174
- run: yarn test:plugins:ci
175+
env:
176+
NODE_OPTIONS: ${{ matrix.node-opts }}
171177
- if: always()
172178
uses: ./.github/actions/testagent/logs
173179
with:

0 commit comments

Comments
 (0)