v5.51.1 proposal #5664
Closed
v5.51.1 proposal #5664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dd-trace-js[bot]](https://avatars.githubusercontent.com/in/1216021?s=60&v=4){kind=small}
Overall package sizeSelf size: 9.3 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 3.3.1 | 13.99 MB | 13.99 MB | | @datadog/pprof | 5.7.1 | 9.51 MB | 9.88 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v5.x #5664 +/- ##
=======================================
Coverage ? 79.04%
=======================================
Files ? 513
Lines ? 23407
Branches ? 0
=======================================
Hits ? 18501
Misses ? 4906
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 935 Passed, 0 Skipped, 17m 8.18s Total Time |
Due to a bug in how the tracer configuration was parsed, older versions of the
tracer would always have Code Origin for entry spans enabled, no matter if it
was disabled in config (which it was supposed to be by default). This bug only
applied to Code Origin for entry spans on Fastify, whereas Code Origin for exit
spans correctly adhered to the config.
This bug has been precent in the tracer since Code Origin for Spans was added
in v5.24.0 on October 17th 2024 and there has not been any reports of issues
related to this. Based on that, Code Origin for Spans will now be enabled by
default. The main functional difference with this commit, is that the feature
can now actually be turned off using the config.
Code Origin for exit spans are still experimental:
Since Code Origin for exit spans was never affected by this bug, we have
decided to leave this feature as opt-in, which means it's going to be off by
default. A new experimental config option has been introduced to allow users to
enable/disable Code Origin for exit spans independently, either via an
environment variable:
DD_CODE_ORIGIN_FOR_SPANS_EXPERIMENTAL_EXIT_SPANS_ENABLED=true
Or via inline config:
tracer.init({
codeOriginForSpans: {
experimental: {
exit_spans: { enabled: true }
}
}
})
dd-trace-js
bot
force-pushed
the
v5.51.1-proposal
branch
from
ebd46e3 to
4e9da0c
Compare
|
Superseded by #5684. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f9b709b11b] - (SEMVER-PATCH) Revert "node action default version" (Roch Devost) #56759721d0895f] - (SEMVER-PATCH) switch to default github token for ci visibility benchmark (Roch Devost) #5639b1727dd9bf] - (SEMVER-PATCH) [Code Origin for Spans] Allow code origin to be disabled (Thomas Watson) #563554c86664a9] - (SEMVER-PATCH) use a fixed version for latest in node action (Roch Devost) #5671108c0b4fba] - (SEMVER-PATCH) fix release proposal not closing patch pr on minor (Roch Devost) #5663