Skip to content

Fix Node 24 warning for invoking fs.existsSync with invalid argument type #5687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented May 9, 2025

What does this PR do?

Fix Node 24 warning for invoking fs.existsSync with invalid argument type

Motivation

Node 24 prints:

(node:83412) [DEP0187] DeprecationWarning: Passing invalid argument types to fs.existsSync is deprecated

on console otherwise.

@szegedi szegedi requested a review from a team as a code owner May 9, 2025 09:26
Copy link

github-actions bot commented May 9, 2025

Overall package size

Self size: 9.31 MB
Deduped: 102.56 MB
No deduping: 103.08 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 3.3.1 | 13.99 MB | 13.99 MB | | @datadog/pprof | 5.7.1 | 9.51 MB | 9.88 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@szegedi szegedi marked this pull request as draft May 9, 2025 09:27
@szegedi szegedi force-pushed the szegedi/fix-deprecation branch from 1a11903 to 4823c41 Compare May 9, 2025 09:28
@szegedi szegedi force-pushed the szegedi/fix-deprecation branch from 4823c41 to 05261aa Compare May 9, 2025 09:29
@szegedi szegedi marked this pull request as ready for review May 9, 2025 09:30
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.09%. Comparing base (8d6b823) to head (05261aa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5687   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files         513      513           
  Lines       23525    23524    -1     
=======================================
  Hits        18606    18606           
+ Misses       4919     4918    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: szegedi/fix-deprecation
Commit report: 9ce1014
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 934 Passed, 0 Skipped, 12m 21.26s Total Time

@pr-commenter
Copy link

pr-commenter bot commented May 9, 2025

Benchmarks

Benchmark execution time: 2025-05-09 09:44:40

Comparing candidate commit 05261aa in PR branch szegedi/fix-deprecation with baseline commit 8d6b823 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1272 metrics, 51 unstable metrics.

@szegedi szegedi merged commit 052bdaa into master May 9, 2025
437 of 466 checks passed
@szegedi szegedi deleted the szegedi/fix-deprecation branch May 9, 2025 09:51
@dd-trace-js dd-trace-js bot mentioned this pull request May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants