Skip to content

simpler adding --no-async-context-frame #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented May 13, 2025

And more correct.

@bengl bengl requested a review from a team as a code owner May 13, 2025 13:20
Copy link

github-actions bot commented May 13, 2025

Overall package size

Self size: 9.36 MB
Deduped: 103.39 MB
No deduping: 103.91 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@87fcd71). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5717   +/-   ##
=========================================
  Coverage          ?   79.01%           
=========================================
  Files             ?      514           
  Lines             ?    23506           
  Branches          ?        0           
=========================================
  Hits              ?    18574           
  Misses            ?     4932           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented May 13, 2025

Benchmarks

Benchmark execution time: 2025-05-13 17:57:05

Comparing candidate commit 19142c2 in PR branch bengl/simpler-acf-check with baseline commit 87fcd71 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1263 metrics, 60 unstable metrics.

@BridgeAR
Copy link
Collaborator

The CI failure seems unrelated as it also fails on master: https://github.com/DataDog/dd-trace-js/actions/runs/15000186690/job/42144791850

@bengl bengl force-pushed the bengl/simpler-acf-check branch from d7ad478 to 19142c2 Compare May 13, 2025 17:45
@bengl bengl enabled auto-merge (squash) May 13, 2025 17:45
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: bengl/simpler-acf-check
Commit report: 7412e0a
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 511 Passed, 0 Skipped, 15m 46.51s Total Time

@bengl bengl merged commit fcf95b2 into master May 13, 2025
585 of 587 checks passed
@bengl bengl deleted the bengl/simpler-acf-check branch May 13, 2025 18:09
dd-trace-js bot pushed a commit that referenced this pull request May 13, 2025
@dd-trace-js dd-trace-js bot mentioned this pull request May 13, 2025
bengl added a commit that referenced this pull request May 13, 2025
szegedi added a commit that referenced this pull request May 16, 2025
szegedi added a commit that referenced this pull request May 16, 2025
szegedi added a commit that referenced this pull request Jun 4, 2025
szegedi added a commit that referenced this pull request Jun 11, 2025
szegedi added a commit that referenced this pull request Jun 25, 2025
szegedi added a commit that referenced this pull request Jun 26, 2025
szegedi added a commit that referenced this pull request Jun 30, 2025
szegedi added a commit that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants