Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.2.0 proposal #27578

Merged
merged 106 commits into from
May 7, 2019
Merged

v12.2.0 proposal #27578

merged 106 commits into from
May 7, 2019

Conversation

targos
Copy link
Member

@targos targos commented May 6, 2019

2019-05-07, Version 12.2.0 (Current), @targos

Notable changes

  • deps:
    • Updated llhttp to 1.1.3. This fixes a bug that made Node.js' HTTP parser
      refuse any request URL that contained the "|" (vertical bar) character (Fedor Indutny) #27595.
  • tls:
    • Added an enableTrace() method to TLSSocket and an enableTrace option
      to tls.createServer(). When enabled, TSL packet trace information is
      written to stderr. This can be used to debug TLS connection problems (cjihrig) #27497, (Sam Roberts) #27376.
  • cli:
    • Added a --trace-tls command-line flag that enables tracing of TLS
      connections without the need to modify existing application code (cjihrig) #27497.
    • Added a --cpu-prof-interval command-line flag. It can be used to specify
      the sampling interval for the CPU profiles generated by --cpu-prof (Joyee Cheung) #27535.
  • module:
    • Added the createRequire() method. It allows to create a require function
      from a file URL object, a file URL string or an absolute path string. The
      existing createRequireFromPath() method is now deprecated (Myles Borins) #27405.
    • Throw on require('./path.mjs'). This is technically a breaking change that
      should have landed with Node.js 12.0.0. It is necessary to have this to keep
      the possibility for a future minor version to load ES Modules with the
      require function (Myles Borins) #27417.
  • repl:
    • The REPL now supports multi-line statements using BigInt literals as well
      as public and private class fields and methods (Ruben Bridgewater) #27400.
    • The REPL now supports tab autocompletion of file paths with fs methods (Anto Aravinth) #26648.
  • meta:

Commits

  • [c0ab2a141b] - assert: use new language features (Ruben Bridgewater) #27400
  • [4b3d0d1953] - async_hooks: fixup do not reuse HTTPParser (Gerhard Stoebich) #27477
  • [cfc7bdd303] - benchmark: add benchmark for node -p (Joyee Cheung) #27320
  • [53eefeb73e] - buffer: remove unreachable code (Rich Trott) #27445
  • [cac584d260] - buffer,errors: improve bigint, big numbers and more (Ruben Bridgewater) #27228
  • [22a5a05785] - build: delegate building from Makefile to ninja (Refael Ackermann) #27504
  • [67205f5941] - build: remove unsupported Python 2.6 from configure (cclauss) #27381
  • [615d386390] - child_process: only stop readable side of stream passed to proc (Anna Henningsen) #27373
  • [8e876e60aa] - console: use consolePropAttributes for k-bind properties (reland) (Ruben Bridgewater) #27352
  • [55804e1726] - deps: update llhttp to 1.1.2 (Fedor Indutny) #27513
  • [f142363cfa] - deps: update llhttp to 1.1.3 (Fedor Indutny) #27595
  • [5f72246499] - deps: add acorn stage-3 plugins (Ruben Bridgewater) #27400
  • [230a773e32] - (SEMVER-MINOR) deps: update archs files for OpenSSL-1.1.1b (Sam Roberts) #27376
  • [b68132e01a] - (SEMVER-MINOR) deps: configure OpenSSL's SSL_trace to be built (Sam Roberts) #27376
  • [7c25dce7ba] - deps: V8: cherry-pick 5d0cf6b (Joyee Cheung) #27423
  • [2c3c0d7d3e] - doc: add cclauss to collaborators (cclauss) #27554
  • [b51dcf62b8] - doc: add Electron 6 to abi_version_registry (Jeremy Apthorp) #27288
  • [cb97de7a9b] - doc: move James back onto TSC (Michael Dawson) #27411
  • [a9748bc124] - doc: describe API ERR_INVALID_PROTOCOL context (Sam Roberts) #27393
  • [a0353fdbe2] - fs: align fs.ReadStream buffer pool writes to 8-byte boundary (ptaylor) #24838
  • [7be1e0af44] - fs: added tests for util file preprocessSymlinkDestination (Ruwan Geeganage) #27468
  • [f882c9b09b] - (SEMVER-MINOR) http: servername === false should disable SNI (Fedor Indutny) #27316
  • [de337bb37c] - (SEMVER-MINOR) inspector: implement --cpu-prof-interval (Joyee Cheung) #27535
  • [9c842f4119] - lib: remove Reflect.apply where appropriate (Anatoli Papirovski) #27349
  • [47d311b3f0] - lib: remove outdated optimizations (Weijia Wang) #27380
  • [c2a03d58c3] - lib: print to stdout/stderr directly instead of using console (Joyee Cheung) #27320
  • [b68ecf3e17] - meta: move andrasq to Collaborator Emeriti list (Rich Trott) #27546
  • [fd17f37a83] - meta: move stefanmb to Collaborator Emeriti list (Rich Trott) #27502
  • [8495e8bceb] - meta: move Forrest Norvell to Collaborator Emeriti list (Rich Trott) #27437
  • [7d1c90b614] - meta: move @vsemozhetbyt to collaborator emeriti (Vse Mozhet Byt) #27412
  • [014a9fd46f] - module: throw on require('./path.mjs'); (Myles Borins) #27417
  • [5bcd7700ca] - (SEMVER-MINOR) module: add createRequire method (Myles Borins) #27405
  • [be9a1ec1d1] - module: allow passing a directory to createRequireFromPath (Gilles De Mey) #23818
  • [e5fdc30bd1] - n-api: make napi_get_property_names return strings (Anna Henningsen) #27524
  • [826fb66729] - process: compatibility patch to backport 1d022e8 (Ruben Bridgewater) #27483
  • [91b7f5e103] - process: improve cwd performance (Ruben Bridgewater) #27224
  • [05cea679a3] - repl: handle stage-3 language features properly (Ruben Bridgewater) #27400
  • [01d632d7e8] - repl: add new language features to top level await statements (Ruben Bridgewater) #27400
  • [149412ca02] - repl: add autocomplete for filesystem modules (Anto Aravinth) #26648
  • [a55457c713] - report: use const reference in node_report.cc (gengjiawen) #27479
  • [8724229155] - src: make deleted function public in node_native_module.h (gengjiawen) #27509
  • [1489d12735] - src: make deleted function public in node_main_instance.h (gengjiawen) #27509
  • [294d2ea71d] - (SEMVER-MINOR) src: refactor V8ProfilerConnection::DispatchMessage() (Joyee Cheung) #27535
  • [a758f9bdf5] - src: remove node_options-inl.h from header files (Sam Roberts) #27538
  • [bb373d0def] - src: remove unnecessary semicolons after macros (Yang Guo) #27529
  • [0c9bc02b96] - src: refactor V8ProfilerConnection to be more reusable (Joyee Cheung) #27475
  • [c787bb85cd] - src: refactor profile initialization (Joyee Cheung) #27475
  • [600048b1b7] - src: move Environment::context out of strong properties (Joyee Cheung) #27430
  • [33702913b1] - src: prefer v8::Global over node::Persistent (Anna Henningsen) #27287
  • [9d6d45e7d2] - stream: remove TODO and add a description instead (Ruben Bridgewater) #27086
  • [bb1eaeec75] - test: mark test-tls-enable-trace-cli flaky (cjihrig) #27559
  • [d648ecc488] - test: improve test-async-hooks-http-parser-destroy (Rich Trott) #27319
  • [ca720b3a55] - test: converting NghttpError to string in HTTP2 module (Ruwan Geeganage) #27506
  • [99e4a576eb] - test: add mustCall to openssl-client-cert-engine (Boxuan Li) #27474
  • [e1d88aa880] - test: document NODE_COMMON_PORT env var (cjihrig) #27507
  • [66cf706521] - test: allow EAI_FAIL in test-http-dns-error.js (cjihrig) #27500
  • [df4246e3b6] - test: refactor and deflake test-tls-sni-server-client (Luigi Pinca) #27426
  • [a278814818] - test: make sure weak references are not GCed too early (Ruben Bridgewater) #27482
  • [aa281d284a] - test: better output for test-report-uv-handles.js (gengjiawen) #27479
  • [86c27c6005] - test: add mustcall in test-net-bytes-read.js (imhype) #27471
  • [33fead3f5e] - Revert "test: skip test-cpu-prof in debug builds with code cache" (Anna Henningsen) #27469
  • [a9a85d6271] - test: check napi\_get\_reference\_value() during finalization (Anna Henningsen) #27470
  • [16af9435a0] - test: remove flaky designation for test-tls-sni-option (Luigi Pinca) #27425
  • [1b94d025bc] - test: add missing line breaks to keep-alive header of slow headers test (Shuhei Kagawa) #27442
  • [fefbbd90af] - test: add tests for new language features (Ruben Bridgewater) #27400
  • [3711684ccf] - test: add mustCall for parallel/test-net-connect-paused-connection (sujunfei) #27463
  • [0e4f8788eb] - test: add mustCallAtLeast to test-fs-read-stream-resume.js (heben) #27456
  • [e89b6fee3a] - test: adding mustCall in test-fs-readfile-empty.js (陈健) #27455
  • [457549b67d] - test: add common.mustCall in test-http-abort-client.js (OneNail) #27449
  • [f4124d5ba5] - test: add mustCall to http-abort-queued test (Yaphet Ye) #27447
  • [e21f035666] - test: add mustCall in test-fs-readfilesync-pipe-large.js (sinoon) #27458
  • [1dd0205f10] - test: add mustCall to test-dgram-connect-send-multi-buffer-copy.js (XGHeaven) #27465
  • [0dfe5bebb2] - test: add test of policy about parse error (Daiki Ihara) #26873
  • [eeab007b25] - test: add mustCall to test-net-after-close test (xuqinggang) #27459
  • [c1b04652f5] - test: add "mustCall" to test-fs-readfile-unlink (wuchenkai) #27453
  • [b6c65c1351] - test: add missing ToC entries (cjihrig) #27434
  • [66bff5071f] - test: document report helper module (cjihrig) #27434
  • [2c335928cd] - test: document NODE_SKIP_FLAG_CHECK (cjihrig) #27434
  • [115d06cdbb] - test: document NODE_TEST_KNOWN_GLOBALS (cjihrig) #27434
  • [51fc672da9] - test: add mustCallAtLeast to test-fs-read-stream-inherit (nilianzhu) #27457
  • [4b9d109518] - test: add mustCall to test-dgram-implicit-bind.js (Chenxi Yuan) #27452
  • [c4d67f2af5] - test: add common.mustCall test-dgram-listen-after-bind (zhoujiamin) #27454
  • [23fb430e03] - test: add mustCall to test-dgram-connect-send-callback-buffer (shenchen) #27466
  • [a37ca245ff] - test: add mustCallAtLeast to test-fs-read-stream-fd test (hardfist) #27461
  • [cf84f20453] - test: skip fs-copyfile-respect-permission if root (Daniel Bevenius) #27378
  • [7d80999454] - test: add mustCall to net-can-reset-timeout (xinyulee) #27462
  • [9fa5ba8b3c] - test: add mustCall to test-fs-readfile-pipe-large (luoyu) #27460
  • [e8d5b6226a] - test: add "mustCall" for test-net-buffersize (lixin.atom) #27451
  • [d784ecb1ad] - test: add mustCall to test-net-eaddrinuse test (tongshouyu) #27448
  • [6fd1384a43] - test: add mustcall in test-dgram-connect-send-callback-buffer-length (jyjunyz) #27464
  • [7a35077197] - test: add mustCall to test-fs-readfile-pipe (tonyhty) #27450
  • [af29ae0344] - test: add mustCall to net-connect-buffer test (Rongjian Zhang) #27446
  • [bdabf699eb] - (SEMVER-MINOR) tls: add --tls-min-v1.2 CLI switch (Sam Roberts) #27520
  • [7bbf951095] - tls: disallow conflicting TLS protocol options (Sam Roberts) #27521
  • [84a2768c25] - (SEMVER-MINOR) tls: support enableTrace in TLSSocket() (cjihrig) #27497
  • [576fe339a1] - (SEMVER-MINOR) tls: simplify enableTrace logic (cjihrig) #27497
  • [30a72e8c7b] - (SEMVER-MINOR) tls: allow enabling the TLS debug trace (Sam Roberts) #27376
  • [f1efe6dae0] - (SEMVER-MINOR) tls,cli: add --trace-tls command-line flag (cjihrig) #27497
  • [3d37414002] - tools: fix node-core/required-modules eslint rule (Ben Noordhuis) #27545
  • [29e2793a87] - tools: add Release and Debug symlinks to .gitignore (Gerhard Stoebich) #27484
  • [76af4f0d05] - tools: prohibit assert.doesNotReject() in Node.js core (Ruben Bridgewater) #27402
  • [95498df1cf] - util: inspect constructor closer (Ruben Bridgewater) #27522
  • [7b5bd93ced] - util: compatibility patch to backport d0667e8 (Ruben Bridgewater) #27570
  • [52d4f1febf] - util: improve function inspection (Ruben Bridgewater) #27227
  • [caab7d4664] - util: better number formatters (Ruben Bridgewater) #27499

BridgeAR and others added 30 commits April 29, 2019 16:57
This makes sure we do not use `assert.doesNotReject()` anywhere in
our code base. This is just a simple wrapper that catches the
rejection and then rejects it again in case of an error. Thus, it is
not useful to do that.

The error message for `assert.doesNotThrow()` is also improved.

PR-URL: #27402
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This patch adds an internal function that prints to stdout or
stderr by directly writing to the known file descriptor, and
uses it internally in common cases to avoid the overhead
of the console implementation.

PR-URL: #27320
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #27320
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #27446
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #27450
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
add mustcall() on client.bind callback

PR-URL: #27464
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #27448
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #27451
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
PR-URL: #27460
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
PR-URL: #27462
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original commit message:

    [snapshot] Use Handle to track name in `CodeSerializer::Deserialize`

    The `Script::InitLineEnds(Handle<Script>(script, isolate));` line
    may lead to objects being moved around on the heap, so it’s necessary
    to use a `Handle` to track that.

    This was causing crashes in Node.js in Debug mode when using the
    code cache in combination with the CPU profiler.

    Refs: #27307
    Change-Id: I392b4c00c6ebad44753f87fcbf2e3278ea7799a6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575698
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61036}

Refs: v8/v8@5d0cf6b

PR-URL: #27423
Fixes: #27307
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #26648
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Currently, if this test is run as the root user the following
failure will occur:

=== release test-fs-copyfile-respect-permissions ===
Path: parallel/test-fs-copyfile-respect-permissions
assert.js:89
  throw new AssertionError(obj);
  ^
AssertionError [ERR_ASSERTION]: Missing expected exception (check).
    at Object.<anonymous>
      (/node/test/parallel/test-fs-copyfile-respect-permissions.js:38:10)
    at Module._compile (internal/modules/cjs/loader.js:759:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
    at Module.load (internal/modules/cjs/loader.js:628:32)
    at Function.Module._load (internal/modules/cjs/loader.js:555:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:826:10)
    at internal/main/run_main_module.js:17:11
Command:
out/Release/node test/parallel/test-fs-copyfile-respect-permissions.js
[05:41|% 100|+ 2620|-   1]: Done

This commit adds a root user check and skips this test if running as the
user root.

PR-URL: #27378
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
PR-URL: #27461
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #27466
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
PR-URL: #27454
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
PR-URL: #27452
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
PR-URL: #27457
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #27380
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
PR-URL: #27434
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #27434
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #27434
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
These modules were already documented, but not included in the
table of contents.

PR-URL: #27434
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Add common.mustCall to test-fs-readfile-unlink

PR-URL: #27453
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closing the underlying resource completely has the unwanted side effect
that the stream can no longer be used at all, including passing it
to other child processes.

What we want to avoid is accidentally reading from the stream;
accordingly, it should be sufficient to stop its readable side
manually, and otherwise leave the underlying resource intact.

Fixes: #27097
Refs: #21209

PR-URL: #27373
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
OpenSSL doesn't compile `SSL_trace()` by default for historical reasons.
Add the enable-ssl-trace option to the OpenSSL Configure arguments.

PR-URL: #27376
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Ran:

$ cd deps/openssl/config; make

to update deps/openssl/config/archs/ with current configuration.

PR-URL: #27376
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Enable the same trace output that the OpenSSL s_client and s_server
support with their `-trace` option. This is invaluable when debugging
reports of TLS bugs as well as when debugging the internal TLS
implementation.

See:
- #25383
- #17936
- postmanlabs/postman-app-support#5918 (comment)

PR-URL: #27376
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #27412
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This is a reland of #26850.
It was speculatively reverted but it turned out that this did not
cause any trouble.

PR-URL: #27352
Refs: #26943
Refs: #26850
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@antsmartian
Copy link
Contributor

@targos May be #26648, should be part of notable change?

@addaleax
Copy link
Member

addaleax commented May 6, 2019

I think #27584 is a pretty significant regression in v12.x, and I think it might be important to get the (trivial) fix out sooner rather than later. Not saying this release has to wait for it, but if it doesn’t include it, I think I’d like to prepare a small v12.2.1 afterwards if everyone’s okay with that.

@ronkorving
Copy link
Contributor

@targos

It allows to create a require function a file URL object, a file URL string or an absolute path string.

There seems to be a word (or some words) missing here.

@indutny
Copy link
Member

indutny commented May 7, 2019

See #27595

@targos
Copy link
Member Author

targos commented May 7, 2019

If #27595 can be fast-tracked, I'll wait for it.

indutny and others added 2 commits May 7, 2019 16:10
Fixes: #27584
PR-URL: #27595
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Notable changes:

* deps:
  * Updated llhttp to 1.1.3. This fixes a bug that made Node.js' HTTP
    parser refuse any request URL that contained the "|" (vertical bar)
    character. #27595
* tls:
  * Added an `enableTrace()` method to `TLSSocket` and an `enableTrace`
    option to `tls.createServer()`. When enabled, TSL packet trace
    information is written to `stderr`. This can be used to debug TLS
    connection problems. #27497
    #27376
* cli:
  * Added a `--trace-tls` command-line flag that enables tracing of TLS
    connections without the need to modify existing application code.
    #27497
  * Added a `--cpu-prof-interval` command-line flag. It can be used to
    specify the sampling interval for the CPU profiles generated by
    `--cpu-prof`. #27535
* module:
  * Added the `createRequire()` method. It allows to create a require
    function from a file URL object, a file URL string or an absolute
    path string. The existing `createRequireFromPath()` method is now
    deprecated #27405.
  * Throw on `require('./path.mjs')`. This is technically a breaking
    change that should have landed with Node.js 12.0.0. It is necessary
    to have this to keep the possibility for a future minor version to
    load ES Modules with the require function.
    #27417
* repl:
  * The REPL now supports multi-line statements using `BigInt` literals
    as well as public and private class fields and methods.
    #27400
  * The REPL now supports tab autocompletion of file paths with `fs`
    methods. #26648
* meta:
  * Added Christian Clauss (https://github.com/cclauss) to
    collaborators. #27554

PR-URL: #27578
@targos
Copy link
Member Author

targos commented May 7, 2019

Added #27595 and updated the changelog with all suggestions.

@targos
Copy link
Member Author

targos commented May 7, 2019

@targos targos merged commit e8dda76 into v12.x May 7, 2019
targos added a commit that referenced this pull request May 7, 2019
@targos targos deleted the v12.2.0-proposal branch May 7, 2019 18:41
targos added a commit that referenced this pull request May 7, 2019
Notable changes:

* deps:
  * Updated llhttp to 1.1.3. This fixes a bug that made Node.js' HTTP
    parser refuse any request URL that contained the "|" (vertical bar)
    character. #27595
* tls:
  * Added an `enableTrace()` method to `TLSSocket` and an `enableTrace`
    option to `tls.createServer()`. When enabled, TSL packet trace
    information is written to `stderr`. This can be used to debug TLS
    connection problems. #27497
    #27376
* cli:
  * Added a `--trace-tls` command-line flag that enables tracing of TLS
    connections without the need to modify existing application code.
    #27497
  * Added a `--cpu-prof-interval` command-line flag. It can be used to
    specify the sampling interval for the CPU profiles generated by
    `--cpu-prof`. #27535
* module:
  * Added the `createRequire()` method. It allows to create a require
    function from a file URL object, a file URL string or an absolute
    path string. The existing `createRequireFromPath()` method is now
    deprecated #27405.
  * Throw on `require('./path.mjs')`. This is technically a breaking
    change that should have landed with Node.js 12.0.0. It is necessary
    to have this to keep the possibility for a future minor version to
    load ES Modules with the require function.
    #27417
* repl:
  * The REPL now supports multi-line statements using `BigInt` literals
    as well as public and private class fields and methods.
    #27400
  * The REPL now supports tab autocompletion of file paths with `fs`
    methods. #26648
* meta:
  * Added Christian Clauss (https://github.com/cclauss) to
    collaborators. #27554

PR-URL: #27578
targos added a commit to nodejs/nodejs.org that referenced this pull request May 7, 2019
targos added a commit to nodejs/nodejs.org that referenced this pull request May 7, 2019
@targos targos added release Issues and PRs related to Node.js releases. and removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.