Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: allow EAI_FAIL in test-http-dns-error.js #27500

Merged
merged 1 commit into from
May 3, 2019
Merged

test: allow EAI_FAIL in test-http-dns-error.js #27500

merged 1 commit into from
May 3, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 30, 2019

EAI_FAIL is expected on OpenBSD, and has been observed on platforms such as FreeBSD and Windows. This commit makes EAI_FAIL an acceptable error code on all platforms.

Fixes: #27487

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3402

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 30, 2019
richardlau
richardlau approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider printing the actual err.code in the cases where the assertions fail.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 1, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/22857/

EDIT(cjihrig): CI was yellow.

@cjihrig
test: allow EAI_FAIL in test-http-dns-error.js
50364d9 
EAI_FAIL is expected on OpenBSD, and has been observed on
platforms such as FreeBSD and Windows. This commit makes
EAI_FAIL an acceptable error code on all platforms.

PR-URL: nodejs#27500
Fixes: nodejs#27487
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig merged commit 50364d9 into nodejs:master May 3, 2019
@cjihrig cjihrig deleted the test branch May 3, 2019 00:57
targos pushed a commit that referenced this pull request May 4, 2019
@cjihrig @targos
test: allow EAI_FAIL in test-http-dns-error.js
66cf706 
EAI_FAIL is expected on OpenBSD, and has been observed on
platforms such as FreeBSD and Windows. This commit makes
EAI_FAIL an acceptable error code on all platforms.

PR-URL: #27500
Fixes: #27487
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@batrla batrla mentioned this pull request Feb 19, 2020
Closed
2 tasks
BethGriggs pushed a commit that referenced this pull request Feb 24, 2020
@cjihrig @BethGriggs
test: allow EAI_FAIL in test-http-dns-error.js
f1a8791 
EAI_FAIL is expected on OpenBSD, and has been observed on
platforms such as FreeBSD and Windows. This commit makes
EAI_FAIL an acceptable error code on all platforms.

PR-URL: #27500
Fixes: #27487
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 24, 2020
Closed
4 tasks
@BethGriggs BethGriggs mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky parallel/test-http-dns-error.js
4 participants
@cjihrig @nodejs-github-bot @Trott @richardlau