Closed
Conversation
Collaborator
apapirovski
approved these changes
Apr 25, 2019
Contributor
apapirovski
left a comment
apapirovski
left a comment
There was a problem hiding this comment.
The order needs changing but other than that 👍
README.md
Outdated
| **Daniel Bevenius** <daniel.bevenius@gmail.com> (he/him) | ||
| * [fhinkel](https://github.com/fhinkel) - | ||
| **Franziska Hinkelmann** <franziska.hinkelmann@gmail.com> (she/her) | ||
| * [jasnell](https://github.com/jasnell) - |
Contributor
There was a problem hiding this comment.
I believe this should go before Joyee on line 188 rather than here?
gireeshpunathil
approved these changes
Apr 25, 2019
targos
approved these changes
Apr 25, 2019
sam-github
approved these changes
Apr 25, 2019
addaleax
approved these changes
Apr 25, 2019
Member
Author
|
@apapirovski thanks I guess I need to learn the alphabet better :) |
richardlau
approved these changes
Apr 25, 2019
cjihrig
approved these changes
Apr 25, 2019
srl295
approved these changes
Apr 25, 2019
Member
Author
Trott
approved these changes
May 1, 2019
Member
|
Landed in 4206e7c |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 1, 2019
refs: nodejs/TSC#694 PR-URL: nodejs#27411 Refs: nodejs/TSC#694 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 4, 2019
refs: nodejs/TSC#694 PR-URL: #27411 Refs: nodejs/TSC#694 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: nodejs/TSC#694
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes