doc: describe API ERR_INVALID_PROTOCOL context#27393
Closed
sam-github wants to merge 1 commit intonodejs:masterfrom
Closed
doc: describe API ERR_INVALID_PROTOCOL context#27393sam-github wants to merge 1 commit intonodejs:masterfrom
sam-github wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
nodejs-github-bot
added
doc
sam-github
force-pushed
the
doc-invalid-protocol
branch
from
b23eac6 to
a56ff6c
Compare
sam-github
changed the title
Contributor
Author
|
@nodejs/documentation trivial PR, could someone give this a review, please. Note that protocols show up in the node API surface in several places. This error code is unrelated to TLS protocols, for example. The code should probably have had |
BridgeAR
approved these changes
Apr 26, 2019
Contributor
Author
|
@nodejs/collaborators trivial PR, please give it a thumbs up |
BethGriggs
approved these changes
Apr 29, 2019
Trott
approved these changes
Apr 29, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM. I suppose that (from the end-user perspective) it might also be triggered by http.get() and friends? Regardless, I wonder if we should remove this entirely in 13.x and replace with ERR_INVALID_OPT_VALUE.
addaleax
approved these changes
Apr 29, 2019
ERR_INVALID_PROTOCOL docs should describe the API it relates to. See: https://github.com/nodejs/node/pull/27390/files#r278246361
sam-github
force-pushed
the
doc-invalid-protocol
branch
from
a56ff6c to
fe3147f
Compare
trivikr
approved these changes
Apr 30, 2019
antsmartian
approved these changes
Apr 30, 2019
Contributor
Author
|
Landed in dce8806 |
sam-github
added a commit
that referenced
this pull request
Apr 30, 2019
ERR_INVALID_PROTOCOL docs should describe the API it relates to. See: https://github.com/nodejs/node/pull/27390/files#r278246361 PR-URL: #27393 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2019
ERR_INVALID_PROTOCOL docs should describe the API it relates to. See: https://github.com/nodejs/node/pull/27390/files#r278246361 PR-URL: #27393 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERR_INVALID_PROTOCOL docs should describe the API it relates to.
See: https://github.com/nodejs/node/pull/27390/files#r278246361
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes