Revert "Revert "console: use consolePropAttributes for k-bind propert…#27352
Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Closed
Revert "Revert "console: use consolePropAttributes for k-bind propert…#27352BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Conversation
…ies in constructor"" This reverts commit a8eac78.
Collaborator
nodejs-github-bot
added
the
console
danbev
approved these changes
Apr 23, 2019
refack
approved these changes
Apr 23, 2019
This comment has been minimized.
This comment has been minimized.
refack
added
the
author ready
This comment has been minimized.
This comment has been minimized.
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22729/ ✅ (besides Windows) |
Member
Author
|
@nodejs/tsc I am not certain if I should stick to the commit message. We normally do that in case of an revert but in this case our subsystem validation complains about the commit message. Any suggestions? |
Member
|
I'd just keep the message of the original commit. And maybe add something like |
Trott
approved these changes
Apr 27, 2019
Member
Author
|
Landed in 6bfde6a 🎉 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 29, 2019
This is a reland of nodejs#26850. It was speculatively reverted but it turned out that this did not cause any trouble. PR-URL: nodejs#27352 Refs: nodejs#26943 Refs: nodejs#26850 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2019
This is a reland of #26850. It was speculatively reverted but it turned out that this did not cause any trouble. PR-URL: #27352 Refs: #26943 Refs: #26850 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ies in constructor""
This reverts commit a8eac78.
The revert turned out not to be the actual cause of the test failure. Random changes caused the test to constantly fail.
Refs: #26401 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes