Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test:add common.mustCall in test-http-abort-client.js #27449

Closed
wants to merge 1 commit into from
Closed

test:add common.mustCall in test-http-abort-client.js #27449

wants to merge 1 commit into from

Conversation

y1d7ng
Copy link
Contributor

@y1d7ng y1d7ng commented Apr 28, 2019 •
edited
Loading

refactor test-http-abort-client to use common.mustCall (from: code-and-learn)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 28, 2019
@oyyd oyyd added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 28, 2019
@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22761/

@oyyd
Copy link
Contributor

oyyd commented Apr 28, 2019

Hi, @OneNail . Can you add a space after "test:" like test: add common.mustCall in test-http-abort and make sure the commit message is less than 75 chars per line ?

@y1d7ng y1d7ng force-pushed the refactorTestHttpAbortClient branch from b67bf3a to 7e2460e Compare April 28, 2019 10:48
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22776/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22800/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22810/

@oyyd
Copy link
Contributor

oyyd commented Apr 30, 2019

Landed in 578b31e, thanks!

You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute.

@oyyd oyyd closed this Apr 30, 2019
oyyd pushed a commit that referenced this pull request Apr 30, 2019
@y1d7ng @oyyd
test: add common.mustCall in test-http-abort-client.js
578b31e 
PR-URL: #27449
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 30, 2019
@y1d7ng @targos
test: add common.mustCall in test-http-abort-client.js
457549b 
PR-URL: #27449
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request May 8, 2019
Closed
@molllyn1 molllyn1 mentioned this pull request Apr 15, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Apr 15, 2024
Open
@kissofire kissofire mentioned this pull request Apr 15, 2024
Open
@137717unity 137717unity mentioned this pull request Apr 15, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Apr 15, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@starkwang starkwang starkwang approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@yorkie yorkie yorkie approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@y1d7ng @nodejs-github-bot @oyyd @Trott @yorkie @cjihrig @gireeshpunathil @starkwang @ZYSzys