test: add mustCall to test-dgram-implicit-bind test#27452
Closed
yuanchenxi95 wants to merge 1 commit intonodejs:masterfrom
yuanchenxi95:master
Closed
test: add mustCall to test-dgram-implicit-bind test#27452yuanchenxi95 wants to merge 1 commit intonodejs:masterfrom yuanchenxi95:master
yuanchenxi95 wants to merge 1 commit intonodejs:masterfrom
yuanchenxi95:master
Conversation
joyeecheung
added
the
code-and-learn
joyeecheung
approved these changes
Apr 28, 2019
Collaborator
yorkie
approved these changes
Apr 28, 2019
gireeshpunathil
approved these changes
Apr 28, 2019
gireeshpunathil
added
the
author ready
Member
|
please leave 👍 to fast-track |
cjihrig
approved these changes
Apr 28, 2019
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
I don't think this is necessary, but the code LGTM.
ZYSzys
approved these changes
Apr 29, 2019
Contributor
|
Landed in c3d4933, thanks! You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute. |
pull bot
pushed a commit
to SimenB/node
that referenced
this pull request
Apr 29, 2019
PR-URL: nodejs#27452 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 29, 2019
PR-URL: #27452 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes