test: add missing line breaks to keep-alive header of slow headers test#27442
Closed
shuhei wants to merge 1 commit intonodejs:masterfrom
Closed
test: add missing line breaks to keep-alive header of slow headers test#27442shuhei wants to merge 1 commit intonodejs:masterfrom
shuhei wants to merge 1 commit intonodejs:masterfrom
Conversation
Trott
approved these changes
Apr 28, 2019
Collaborator
ZYSzys
approved these changes
Apr 28, 2019
ZYSzys
added
the
author ready
mihalskiy
approved these changes
Apr 28, 2019
lpinca
approved these changes
Apr 28, 2019
Member
|
Landed in e4e6a33 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 30, 2019
PR-URL: nodejs#27442 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 4, 2019
PR-URL: #27442 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\r\nis missing in the HTTP header in the slow headers test with keep-alive, andConnectionandAgentheaders are not effectively sent to the server. However, it shouldn't affect the behavior of the test because HTTP 1.1 uses persistent connection by default even ifConnection: keep-aliveis not specified.This PR fixes it just for the sake of correctness.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes