Skip to content

meta: move @vsemozhetbyt to collaborator emeriti#27412

Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-me-to-emeritus
Closed

meta: move @vsemozhetbyt to collaborator emeriti#27412
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-me-to-emeritus

Conversation

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Apr 25, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Unfortunately, I will not be able to help the project in the foreseeable future due to some personal reasons.

Thank you for the wonderful atmosphere and experience)

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Apr 25, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 25, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3365

targos
targos approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for everything that you've done for the project!

refack
refack approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@sam-github
Copy link
Contributor

sam-github commented Apr 25, 2019

You did amazing work, thank you! And I hope we'll see you back again.

@lpinca
Copy link
Member

lpinca commented Apr 25, 2019 •
edited
Loading

I will not forget your dedication and attention to improve the documentation. A necessary part of any successful project which is boring to deal with. Thank you so much for your work. I also hope to see you back soon.

cjihrig
cjihrig approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for everything!

antsmartian
antsmartian approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@antsmartian antsmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work!

@jasnell
Copy link
Member

jasnell commented Apr 26, 2019

thank you for everything I hope you're able to come back to the project, but either way, know that your contributions have been highly valued

apapirovski
apapirovski approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for everything you've done for Node.js, especially around documentation!

BridgeAR
BridgeAR approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work and I hope to see you back at some point!

mhdawson
mhdawson approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hope to see you back in the future.

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 29, 2019

Can anybody land this, please) I've left the Collaborators team and I have not access to write. Thanks)

@Trott
Copy link
Member

Trott commented Apr 29, 2019

Landed in d088587

@Trott Trott closed this Apr 29, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 29, 2019
@vsemozhetbyt @Trott
meta: move @vsemozhetbyt to collaborator emeriti
d088587 
PR-URL: nodejs#27412
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the doc-me-to-emeritus branch April 29, 2019 18:29
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 29, 2019

Thank you all for the kind words!

targos pushed a commit that referenced this pull request Apr 30, 2019
@vsemozhetbyt @targos
meta: move @vsemozhetbyt to collaborator emeriti
7d1c90b 
PR-URL: #27412
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

+3 more reviewers

@apapirovski apapirovski apapirovski approved these changes

@refack refack refack approved these changes

@antsmartian antsmartian antsmartian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.