Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 4, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 4, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22948/

EDIT(cjihrig): CI was yellow.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 4, 2019
@Trott
Copy link
Member

Trott commented May 6, 2019

Landed in 9c43e7a

@Trott Trott closed this May 6, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 6, 2019
PR-URL: nodejs#27559
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 6, 2019
PR-URL: #27559
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request May 6, 2019
@cjihrig cjihrig deleted the flake branch May 6, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants