test: add test of policy about parse error#26873
Closed
sasurau4 wants to merge 2 commits intonodejs:masterfrom
Closed
test: add test of policy about parse error#26873sasurau4 wants to merge 2 commits intonodejs:masterfrom
sasurau4 wants to merge 2 commits intonodejs:masterfrom
Conversation
Member
|
@nodejs/testing PTAL |
BridgeAR
approved these changes
Apr 16, 2019
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM but it would be nice to address the comments before landing.
Contributor
Author
|
@BridgeAR Thanks for your review. I fixed that you pointed out. 👍 |
BridgeAR
added
the
author ready
Collaborator
Trott
approved these changes
Apr 29, 2019
Collaborator
Member
|
Landed in a565853 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 29, 2019
PR-URL: nodejs#26873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2019
PR-URL: #26873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test cases of policy when the error
ERR_SRI_PARSEoccurs.The current coverage about sri is here.
I add a new file
test-policy-parse-integrity.jsbecause I think it's too complicated when I enhanced thetest-policy-integrity.jsto pass the invalid integrity string.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes