Skip to content

V1.5.7 #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Oct 20, 2021
Merged

V1.5.7 #2051

merged 29 commits into from
Oct 20, 2021

Conversation

@mayanje
Copy link
Contributor

@mayanje mayanje commented Oct 19, 2021 •
edited
Loading

V1.5.7

This release 1.5.7 is mainly for bugs fix and miscellaneous evolutions.

Changelog

New options

LSP evolutions

CFG/DFA evolutions

Code profiling

Internal code representation changes

Errors checking & diagnostics reporting

Bugs fix

fm-117 and others added 28 commits July 1, 2021 09:10
@fm-117
WI #1990 Fix type comparison in procedure call checker (#1993)
a41d44b
@fm-117
WI #1997 Always create code element for ACCEPT statement (#1998)
cbe64a8
@delevoye
WI #1926 Correct duplicate diagnostics on CALL using special register…
41be281 
… by reference (#1994)
@fm-117
WI #1992 Ensure correct token types are used for AlphanumericValue (#…
1a4d2a4 
…1999)
@fm-117
WI #2007 Enable optional diagnostics for CFG (#2008)
2ca4582 
* WI #2007 Defer CFG diagnostics creation

* WI #2007 Add optional CFG diagnostics options

* WI #2007 Set CFG checks severity according to their selected level
@mayanje
WI #2014 Add basic dominator algorithms (#2015)
e0d65ad 
* WI #2014 Add basic dominator algorithms

* WI #2014 Simply result format

* WI #2014 Change Review

* WI #2014 make DumpDominators static
@mayanje
WI #2011 Add -now --nowatchers options (#2013)
5d990e8 
* WI #2011 Add -now --nowatchers options

* WI #2011 Change review
@mayanje
WI #2009 Bad assign DiagnosticsDetected elsewhere (#2010)
d075552 
* WI #2009 Bad assign DiagnosticsDetected elsewhere

* WI #2009 use events
@delevoye
WI #2005 Convert ClassCondition.DataItem to ConditionalOperand (#2006)
ceda343 
* WI #2005 Convert ClassCondition.DataItem to ConditionalOperand
@delevoye
WI #2000 Add resolved paragraphs and sections to Sort node (#2003)
2a21fef 
* WI #2000 Add resolved paragraphs and sections to Sort node
@fm-117
WI #400 Check literals used as subscripts (#2004)
0b45cc3
@fm-117
WI #1911 Implement advanced PICTURE string validation (#2020)
58c1577
@delevoye
WI #2012 Add diagnostic on MOVE from PIC X to Numeric with usage (#2017)
5d35944 
* WI #2012 Create a diagnostic on MOVE from PIC X to a numeric with an usage

* WI #2012 Change diagnostic message and add test

* WI #2012 Correct tests failed because of new diagnostic

* WI #2012 Shorten diagnostic message and remove cast to use StorageAreaKind

* WI#2012 Use else if because StorageAreaKind are exclusive
@mayanje @fm-117
WI #1985 Add -cpyr option (#1986)
e864f00 
* WI #1985 Add -cpyr option

* WI #1985 Use CompilationDocument for collecting

* WI #1985 Review changes

* WI #1985 Correct indents

* WI #1985 Fix typo in comment

Co-authored-by: fm-117 <milletfl@e-i.com>
Co-authored-by: fm-117 <51322634+fm-117@users.noreply.github.com>
@mayanje @fm-117
WI #1975 Add cpyCopies field (#1979)
8312290 
* WI #1975 Add cpyCopies field

* WI #1975 Implementing Lookup

* WI #1975 Rename field

Co-authored-by: fm-117 <51322634+fm-117@users.noreply.github.com>
Co-authored-by: fm-117 <milletfl@e-i.com>
@fm-117
WI #1916 Check WHEN condition in binary SEARCH statements (#2021)
d5563bf
@fm-117
WI #2016 Implement unreachable code detection (#2023)
aea6c3c
@fm-117
WI #1917 Improve error messages on unexpected dots (#2025)
98f2633
@fm-117
WI #1834 Upgrade to .NET Framework 4.7.2 (#2029)
1e0c13c
@delevoye
WI #1991 Check reference modifiers literals (#2033)
f294bd6 
* WI #1991 Add checks to reference modifiers

* WI #1991 Correct tabs

* WI #1991 Clarify the diagnostic message and uncomment a line in test

* WI #1991 Fix previous commit by replecaing a deleted AddError call
@delevoye
WI #1847 secure external analyzers (#2034)
1e49d0c 
Prevent stopping the parsing because of an external analyzer failure.
@delevoye
WI #1846 Multi line diagnostics (#2036)
fc2429b 
Diagnostics can now be positionned on a range of consecutive lines.
Does not take in account Tokens spread on multiple lines.
@fm-117
WI #2026 #2027 Avoid FileCompiler leaks in LanguageServer (#2030)
94208b4 
* WI #2027 Avoid FileCompiler leaks in Workspace
* WI #2027 Fix LSR test
* WI #2026 Remove static END_OF_FILE token (#2031)
@mayanje @fm-117
2022 abstract int multi branch context (#2024)
387663b 
* WI #2022 Introduce IMultiBranchContext.cs interface

* WI #2022 Adding a comment

* WI #2022 Handling SubContexts

* WI #2022 Handle redirection on PERFORM AFTER branch

* WI #2022 Change Review

* WI #2022 Change review

* WI #2022 replace builder by cfg argument

* WI #2022 Move GetTerminalSuccessorEdges into CFG class

Co-authored-by: fm-117 <milletfl@e-i.com>
@fm-117
WI #2035 Remove semantic domain type flags (#2038)
e20facd
@fm-117
WI #2040 Fix subscript value checking (#2041)
84a21a0
@mayanje @fm-117
WI #2046 Find various NullReferenceException (#2049)
e2893cc 
* WI #2046 Find various NullReferenceException

* WI #2046 Change Review

* WI #2046 use cup preprocessor.

* WI #2046 Refactor Cup vs ANTLR preprocessor choice

Co-authored-by: fm-117 <milletfl@e-i.com>
@fm-117
WI #2037 Avoid creating CE diagnostics after CE build phase (#2043)
041e5c2 
* WI #2037 Check CE diag count in DEBUG

* WI #2037 Apply end misalignment diagnostic on Node instead of CE

* WI #2037 Refactor formalized comments checks

* WI #2037 Check no using on TC procedures

* WI #2037 Move debugging mode check into CE phase instead of Node phase

* WI #2037 Create diagnostic on node instead of CE for duplicate signature check

* WI #2037 Fix indent
@mayanje mayanje self-assigned this Oct 19, 2021
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 19, 2021
@mayanje mayanje requested review from fm-117 and smedilol October 19, 2021 12:12
fm-117
fm-117 approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@fm-117 fm-117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remarks for the changelog:

  • "few meanfull" : miscellaneous ?
  • WI #2037 (PR #2043) is more of a bug fix than a deliberate change to represent data
    Other than that it's all good !

@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 19, 2021
@smedilol
Copy link
Contributor

=> Are more bug fix than Internal code representation changes

WI CFG Detect unreachable Code #2016 Implement unreachable code detection (WI #2016 Implement unreachable code detection #2023)
should be under Errors checking & diagnostics reporting

@mayanje
Copy link
Contributor Author

mayanje commented Oct 19, 2021

Changelog is changed

@mayanje mayanje merged commit 29d4103 into master Oct 20, 2021
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Oct 20, 2021
@mayanje mayanje deleted the v1.5.7 branch October 20, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fm-117 fm-117 fm-117 approved these changes

+1 more reviewer

@smedilol smedilol smedilol approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mayanje mayanje

Labels

✨ Merged Pull Request has been merged successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mayanje @smedilol @fm-117 @delevoye