WI #2016 Implement unreachable code detection #2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayanje
reviewed
Aug 11, 2021
mayanje
previously approved these changes
Aug 12, 2021
delevoye
suggested changes
Aug 16, 2021
Comment on lines
1358
to
1366
| foreach (var unreachableBlockIndex in unreachableBlocks) | ||
| { | ||
| var unreachableBlock = this.CurrentProgramCfgBuilder.Cfg.AllBlocks[unreachableBlockIndex]; | ||
| this.CurrentProgramCfgBuilder.Cfg.AddUnreachableBlock(unreachableBlock); | ||
|
|
||
| var firstInstruction = unreachableBlock.Instructions.First.Value; | ||
| var diagnostic = new Diagnostic(MessageCode.Warning, firstInstruction.CodeElement.Position(), "Unreachable code detected"); | ||
| AddDiagnostic(diagnostic); | ||
| } |
There was a problem hiding this comment.
As you already have the block in the previous for-loop, why do you store them in an HashSet of indexes, to get them again after?
This whole foreach could replace the unreachableBlocks.Add(block.Index); line 1352.
There was a problem hiding this comment.
Well not exactly, in the previous foreach, we may have duplicate of the same block so we still need the HashSet to keep track of unique unreachable blocks. But you're right, we can merge the two loops, using the HashSet only as a marker and not iterating over it.
There was a problem hiding this comment.
Ok, done in 2280c09.
trafico-bot
bot
added
⚠️ Changes requested
trafico-bot
bot
added
🔍 Ready for Review
delevoye
approved these changes
Aug 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2016.
This is a first attempt at unreachable code detection, it should be improved with the support of multiline diagnostics (see #1846) to report unreachable code ranges just like RdZ does.