Skip to content

Conversation

@mayanje
Copy link
Contributor

@mayanje mayanje commented Jun 7, 2021

What have been done
A new field cpyCopies has been added in the class MissingCopiesParams, this field contains all mising CPY Copies.

@mayanje mayanje added this to the CobolEditor milestone Jun 7, 2021
@mayanje mayanje requested review from fm-117 and rooksdo June 7, 2021 16:38
@mayanje mayanje self-assigned this Jun 7, 2021
@fm-117
Copy link
Contributor

fm-117 commented Jun 8, 2021

Also we could use this PR to remove the client to server notification as it is not used, but it requires updates in clients.
See:

  • Workspace.UpdateMissingCopies
  • TypeCobolCustomLanguageServer.OnDidReceiveMissingCopies
  • TypeCobolCustomLanguageServer.CallReceiveMissingCopies

fm-117
fm-117 previously approved these changes Jun 10, 2021
rooksdo
rooksdo previously approved these changes Jun 14, 2021
@mayanje mayanje assigned fm-117 and unassigned fm-117 Aug 9, 2021
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Aug 9, 2021
@fm-117 fm-117 dismissed stale reviews from rooksdo and themself via 1607283 August 9, 2021 13:43
@fm-117 fm-117 requested review from fm-117 and rooksdo August 10, 2021 06:43
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Aug 10, 2021
@mayanje mayanje removed the request for review from rooksdo August 10, 2021 10:10
@mayanje mayanje merged commit 8312290 into develop Aug 10, 2021
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Aug 10, 2021
@fm-117 fm-117 linked an issue Aug 23, 2021 that may be closed by this pull request
@mayanje mayanje mentioned this pull request Oct 19, 2021
@fm-117 fm-117 deleted the 1975_LSP_Add_missingCopiesparams_CPY_Copies branch November 14, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Server Protocol ✨ Merged Pull Request has been merged successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LSP Add to missingCopies params CPY Copies

4 participants