-
Notifications
You must be signed in to change notification settings - Fork 25
WI #1975 Add cpyCopies field #1979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm-117
requested changes
Jun 8, 2021
...guageServer/TypeCobolCustomLanguageServer/Missing Copies Notification/MissingCopiesParams.cs
Outdated
Show resolved
Hide resolved
TypeCobol.LanguageServer/TypeCobolCustomLanguageServer/TypeCobolCustomLanguageServer.cs
Outdated
Show resolved
Hide resolved
|
Also we could use this PR to remove the client to server notification as it is not used, but it requires updates in clients.
|
fm-117
previously approved these changes
Jun 10, 2021
rooksdo
previously approved these changes
Jun 14, 2021
fm-117
approved these changes
Aug 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have been done
A new field cpyCopies has been added in the class MissingCopiesParams, this field contains all mising CPY Copies.