Skip to content

Conversation

@fm-117
Copy link
Contributor

@fm-117 fm-117 commented Sep 3, 2021

Fix #2035.

By removing flags on types, we avoid the issue of misplaced flags on shared types (builtins static instances).

  • It is still possible to flag a symbol and propagate the flag through symbol's type however this should be done only AFTER type expansion
    • one exception, the flag InsideTypedef is allowed to be propagated onto children symbols in a GroupType
  • Builtin symbols are still shared but they are never been flagged after their creation

@fm-117 fm-117 added this to the CobolEditor milestone Sep 3, 2021
@fm-117 fm-117 requested review from delevoye and mayanje September 3, 2021 14:15
@fm-117 fm-117 self-assigned this Sep 3, 2021
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 3, 2021
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 27, 2021
@fm-117 fm-117 merged commit e20facd into develop Sep 27, 2021
@fm-117 fm-117 deleted the 2035_RemoveTypeFlags branch September 27, 2021 13:28
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Sep 27, 2021
@mayanje mayanje mentioned this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Merged Pull Request has been merged successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in symbol/types flags (in semantic domain)

4 participants