WI #2009 Bad assign DiagnosticsDetected elsewhere #2010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm-117
requested changes
Jul 21, 2021
There was a problem hiding this comment.
I think we should also unsubscribe from LoadingIssueEvent, ExceptionTriggered and WarningTrigger in the OnShutdown (so as it mirrors the OnInitialize subscriptions).
Also can you turn these into real event members instead of delegate fields ? This would clarify the intended usage.
DiagnosticsEventDocumentModifiedEventExceptionTriggeredLoadingIssueEventMissingCopiesEventWarningTrigger
trafico-bot
bot
added
⚠️ Changes requested
trafico-bot
bot
added
🔍 Ready for Review
fm-117
approved these changes
Jul 27, 2021
delevoye
approved these changes
Jul 28, 2021
trafico-bot
bot
added
✨ Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have been done
The DiagnosticsEvent was assigned on document opened and document closed. It should not be the case.