WI #2009 Bad assign DiagnosticsDetected elsewhere (#2010)

* WI #2009 Bad assign DiagnosticsDetected elsewhere

* WI #2009 use events

Author: mayanje

TypeCobol.LanguageServer/TypeCobolServer.cs

@@ -260,6 +260,7 @@ protected override InitializeResult OnInitialize(InitializeParams parameters)
             this.Workspace.ExceptionTriggered += ExceptionTriggered;
             this.Workspace.WarningTrigger += WarningTrigger;
             this.Workspace.MissingCopiesEvent += MissingCopiesDetected;
+            this.Workspace.DiagnosticsEvent += DiagnosticsDetected;
             this.Workspace.LoadCustomAnalyzers(CustomAnalyzerFiles);
 
             // Return language server capabilities
@@ -278,6 +279,9 @@ protected override InitializeResult OnInitialize(InitializeParams parameters)
 
         protected override void OnShutdown()
         {
+            this.Workspace.LoadingIssueEvent -= LoadingIssueDetected;
+            this.Workspace.ExceptionTriggered -= ExceptionTriggered;
+            this.Workspace.WarningTrigger -= WarningTrigger;
             this.Workspace.MissingCopiesEvent -= MissingCopiesDetected;
             this.Workspace.DiagnosticsEvent -= DiagnosticsDetected;
 
@@ -307,9 +311,6 @@ protected override void OnDidOpenTextDocument(DidOpenTextDocumentParams paramete
             DocumentContext docContext = new DocumentContext(parameters.textDocument);
             if (docContext.Uri.IsFile && !this.Workspace.TryGetOpenedDocumentContext(docContext.Uri, out _))
             {
-                //Subscribe to diagnostics event
-                this.Workspace.DiagnosticsEvent += DiagnosticsDetected;
-
                 //Create a ILanguageServer instance for the document.
                 docContext.LanguageServer = new TypeCobolLanguageServer(this.RpcServer, parameters.textDocument);
                 docContext.LanguageServer.UseSyntaxColoring = UseSyntaxColoring;
@@ -495,7 +496,6 @@ protected override void OnDidCloseTextDocument(DidCloseTextDocumentParams parame
             if (objUri.IsFile)
             {
                 this.Workspace.CloseSourceFile(objUri);
-                this.Workspace.DiagnosticsEvent -= DiagnosticsDetected;
 
                 // DEBUG information
                 RemoteConsole.Log("Closed source file : " + objUri.LocalPath);

TypeCobol.LanguageServer/Workspace.cs

@@ -47,12 +47,12 @@ public class Workspace
 
         private List<FileCompiler> _fileCompilerWaittingForNodePhase;
         public TypeCobolConfiguration Configuration { get; private set; }
-        public EventHandler<DiagnosticEvent> DiagnosticsEvent { get; set; }
-        public EventHandler<EventArgs> DocumentModifiedEvent { get; set; }
-        public EventHandler<MissingCopiesEvent> MissingCopiesEvent { get; set; }
-        public EventHandler<LoadingIssueEvent> LoadingIssueEvent { get; set; }
-        public EventHandler<ThreadExceptionEventArgs> ExceptionTriggered { get; set; }
-        public EventHandler<string> WarningTrigger { get; set; }
+        public event EventHandler<DiagnosticEvent> DiagnosticsEvent;
+        public event EventHandler<EventArgs> DocumentModifiedEvent;
+        public event EventHandler<MissingCopiesEvent> MissingCopiesEvent;
+        public event EventHandler<LoadingIssueEvent> LoadingIssueEvent;
+        public event EventHandler<ThreadExceptionEventArgs> ExceptionTriggered;
+        public event EventHandler<string> WarningTrigger;
         public Queue<MessageActionWrapper> MessagesActionsQueue { get; private set; }
         private Func<string, Uri, bool> _Logger;       
         /// <summary>