Skip to content

Conversation

@delevoye
Copy link
Contributor

@delevoye delevoye commented Jun 29, 2021

Fix #1926
Diagnostic on LENGTH OF by reference was already there, but another problem appeared:
Parameters were checked multiple times, generating duplicated diagnostics.

@delevoye delevoye added Cobol TypeCobol rfc Specifications are not complete. Comment are welcomed. ErrorMessage Issue related to error messages labels Jun 29, 2021
@delevoye delevoye added this to the CobolEditor milestone Jun 29, 2021
@delevoye delevoye requested review from fm-117, mayanje and rooksdo June 29, 2021 09:09
@delevoye delevoye self-assigned this Jun 29, 2021
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jun 29, 2021
@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jun 29, 2021
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Jun 30, 2021
@delevoye delevoye requested a review from fm-117 July 1, 2021 06:36
@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jul 1, 2021
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Jul 2, 2021
@delevoye delevoye requested a review from fm-117 July 2, 2021 06:46
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 2, 2021
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 12, 2021
@delevoye delevoye merged commit 41be281 into develop Jul 12, 2021
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jul 12, 2021
@delevoye delevoye deleted the 1926_AddDiagnosticCallUsingSpecialRegister branch July 13, 2021 14:06
@mayanje mayanje mentioned this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cobol ErrorMessage Issue related to error messages ✨ Merged Pull Request has been merged successfully rfc Specifications are not complete. Comment are welcomed. TypeCobol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing diagnostic on CALLs using special register

5 participants