WI #2011 Add -now --nowatchers options #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm-117
reviewed
Jul 22, 2021
| { | ||
| _DepWatcher.SetDirectoryWatcher(depFolder); | ||
| _CopyWatcher.Dispose(); | ||
| foreach (var depFolder in Configuration.CopyFolders) |
There was a problem hiding this comment.
naming copyFolder instead of depFolder
There was a problem hiding this comment.
yes done in
0165442
fm-117
approved these changes
Jul 22, 2021
|
This a good remark, tha's why the option is "to disable", so that TC plugin noes not need to be updated. I think -cob option is for specific language COBOL features. But you are right here -now option is for performances in a Cobol editor and LSR mode, and can no be applied to TC. |
trafico-bot
bot
added
✨ Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done
_now, --nowatchers options have been added to TypeCobolLanguageServer projet, so that FileSystemWatcher on Copy and Dependency can be disabled.
Beacuse on change the CopyWatcher used to request the a reparsing on all opened document, and this for each COPY refreshed.