WI #2046 Find various NullReferenceException #2049
Conversation
trafico-bot
bot
added
⚠️ Changes requested
trafico-bot
bot
added
🔍 Ready for Review
| //---------------------------------------------------------- | ||
| // We need to review this mechanism with RTC. | ||
| // Because actually it produces bad results and it will | ||
| // be clarified with RTC specifications. (see TFS 117645) | ||
| //---------------------------------------------------------- | ||
| //missingCopiesParam.Copies = lookup[false].ToList(); | ||
| //missingCopiesParam.CpyCopies = lookup[true].ToList(); | ||
| //---------------------------------------------------------- | ||
| missingCopiesParam.Copies = copiesName; | ||
| missingCopiesParam.CpyCopies = new List<string>(); |
There was a problem hiding this comment.
Copying the discussion from closed #2048, so as to continue it here.
@fm-117
It may produce bad results but it is not related to this issue. I don't see any null refs in the original code so maybe revert this and create a dedicated issue ?@mayanje
The fact is that, this is not compatible with current CobolEditorEI version that's all, so I was not able to test. And in the current version of CobolEditorEI, this concept does not work,@smedilol
Ok, but what about #1975 that request this change. Is it still needed or not ?@mayanje
You are right, it was supposed to be an alternative in editor, but even with that the algorithm suggested in TFS 117645 is not good, so we need to refer to new specification in our internal R 387225.
Does it need to be changed right away ? Couldn't it be adressed in a separate isssue ?
There was a problem hiding this comment.
I did that to stay compatible with the current CobolEditorEI in beta in RDz4EI 7.2, but issue 117645 is reopened and we just received real specification for R 38722 today.
|
@fm-117 just be patient, it will start soon. |
No description provided.