WI #2046 Find various NullReferenceException #2048
Conversation
| //missingCopiesParam.Copies = lookup[false].ToList(); | ||
| //missingCopiesParam.CpyCopies = lookup[true].ToList(); | ||
| //---------------------------------------------------------- | ||
| missingCopiesParam.Copies = copiesName; |
There was a problem hiding this comment.
It doesn't seems related with #2046. Is it an error ?
trafico-bot
bot
added
⚠️ Changes requested
|
The name of the branch is not correct. It's not |
| //---------------------------------------------------------- | ||
| // We need to review this mechanism with RTC. | ||
| // Because actually it produces bad results and it will | ||
| // be clarified with RTC specifications. (see TFS 117645) | ||
| //---------------------------------------------------------- | ||
| //missingCopiesParam.Copies = lookup[false].ToList(); | ||
| //missingCopiesParam.CpyCopies = lookup[true].ToList(); | ||
| //---------------------------------------------------------- | ||
| missingCopiesParam.Copies = copiesName; | ||
| missingCopiesParam.CpyCopies = new List<string>(); |
There was a problem hiding this comment.
It may produce bad results but it is not related to this issue. I don't see any null refs in the original code so maybe revert this and create a dedicated issue ?
There was a problem hiding this comment.
The fact is that, this is not compatible with current CobolEditorEI version that's all, so I was not able to test. And in the current version of CobolEditorEI, this concept does not work,
There was a problem hiding this comment.
Ok, but what about #1975 that request this change. Is it still needed or not ?
There was a problem hiding this comment.
You are right, it was supposed to be an alternative in editor, but even with that the algorithm suggested in TFS 117645 is not good, so we need to refer to new specification in our internal R 387225.
No description provided.