Skip to content

Conversation

@fm-117
Copy link
Contributor

@fm-117 fm-117 commented Aug 16, 2021

  • do not capture FileCompiler instance but Uri instead

  • ensure FileCompiler is removed from all collections when document is closed

  • ensure correct instance is released when clsoing and opening the same document

  • remove static token END_OF_FILE

@fm-117 fm-117 requested review from delevoye and mayanje August 16, 2021 16:20
@fm-117 fm-117 self-assigned this Aug 16, 2021
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Aug 16, 2021
@fm-117 fm-117 linked an issue Aug 17, 2021 that may be closed by this pull request
@fm-117 fm-117 linked an issue Aug 20, 2021 that may be closed by this pull request
@fm-117 fm-117 changed the title WI #2027 Avoid FileCompiler leaks in Workspace WI #2026 #2027 Avoid FileCompiler leaks in LanguageServer Aug 20, 2021
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Aug 31, 2021
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 3, 2021
@fm-117
Copy link
Contributor Author

fm-117 commented Sep 3, 2021

@delevoye Please squash merge this PR after build is ok, thanks.

@delevoye delevoye merged commit 94208b4 into develop Sep 6, 2021
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Sep 6, 2021
@fm-117 fm-117 deleted the 2027_WorkspaceMemoryLeak branch September 20, 2021 07:51
@mayanje mayanje mentioned this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Merged Pull Request has been merged successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data retention in LS semantic updater timer Remove static Token EndOfFile

4 participants