WI #2014 Add basic dominator algorithms #2015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm-117
requested changes
Jul 26, 2021
| if (n == this.RootBlock.Index) | ||
| continue; | ||
| BasicBlock<N, D> b = this.AllBlocks[n]; | ||
| if (b.PredecessorEdges == null) |
There was a problem hiding this comment.
Isn't it a Debug.Assert instead ? We ensure that predecessor edges are set with previous call to SetupPredecessorEdgesFromRoot.
| BitSet doms = dominators[i]; | ||
| if (doms != null) | ||
| { | ||
| BasicBlock<N, D> b = this.AllBlocks[i]; |
There was a problem hiding this comment.
Is b.Index not always equal to i ? Intuitively I thought that this method should be static because it does not depend on the current CFG (except if we include other info from the block).
Also why the double braces ? Is it a common notation ?
There was a problem hiding this comment.
Yes done in
d9ea371
There was a problem hiding this comment.
and
9dcd9e1 double bracket removed
trafico-bot
bot
added
⚠️ Changes requested
trafico-bot
bot
added
🔍 Ready for Review
fm-117
approved these changes
Jul 27, 2021
trafico-bot
bot
added
✨ Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done
Basic dominator algorithms have been added.
Possible Improvement
Later use faster dominator algorithm, but much more complicate to develop and to understand.