-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v14.18.0 release proposal #39990
v14.18.0 release proposal #39990
Commits on Sep 4, 2021
-
PR-URL: #39082 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2884d90 - Browse repository at this point
Copy the full SHA 2884d90View commit details -
doc: fix
EventTarget.dispatchEvent
docsPR-URL: #39127 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 74ba115 - Browse repository at this point
Copy the full SHA 74ba115View commit details -
tools: upgrade
highlight.js
to version 11.0.1Refs: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md PR-URL: #39032 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 70e527c - Browse repository at this point
Copy the full SHA 70e527cView commit details -
test: replace "inspector-cli" with "debugger"
When I moved node-inspect into core, I called a lot of things `inspector-cli` that really should have been `debugger`. This is the last of them to be renamed. PR-URL: #39156 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 62b439e - Browse repository at this point
Copy the full SHA 62b439eView commit details -
doc: use repository instead of repo
Stick with "repository" instead of using both "repository" and "repo". PR-URL: #39157 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1996580 - Browse repository at this point
Copy the full SHA 1996580View commit details -
errors: don't throw TypeError on missing export
Logic in module_job.js assumes detailed stack trace from node_errors.cc which is not populated when --enable-source-maps is set. Fixes #38790 PR-URL: #39017 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for dc855af - Browse repository at this point
Copy the full SHA dc855afView commit details -
We can remove the Acorn plugins as their features are now supported by default. PR-URL: #39166 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for fcae391 - Browse repository at this point
Copy the full SHA fcae391View commit details -
doc: apply logical ordering to CSS variables
The CSS variables are not in any particular logical order as far as I can tell, with certain items that would seem to go together not grouped. This puts them in alphabetical order. PR-URL: #39169 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2629979 - Browse repository at this point
Copy the full SHA 2629979View commit details -
src,zlib: tighten up Z_*_WINDOWBITS macros
PR-URL: #39115 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for c8c290a - Browse repository at this point
Copy the full SHA c8c290aView commit details -
doc: correct JavaScript primitive value names in n-api.md
PR-URL: #39129 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 82458b3 - Browse repository at this point
Copy the full SHA 82458b3View commit details -
doc: fix broken link in errors.md
PR-URL: #39200 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d6a4f8a - Browse repository at this point
Copy the full SHA d6a4f8aView commit details -
doc: use "repository" in maintaining-V8 doc
Use "repository" instead of "repo". This also adjusts capitalization in a header that was already being modified to use "repository" because even I couldn't bring myself to put that in a separate commit. PR-URL: #39179 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4cf17ed - Browse repository at this point
Copy the full SHA 4cf17edView commit details -
doc: remove obsolete cc recommendations
In 2016, Ali added the instruction to cc him on particular V8 bugs and the suggestion to contact him for certain problems. However, I'm pretty sure Ali has not been working on V8 for 2+ years at this point. I'm guessing those instructions are obsolete at this point. (I'll ping him in the PR for this change to confirm, though.) Also: Remove a parenthetical and add a comma, because I can't imagine opening a separate pull request to add a comma. (OK, I'm lying, I totally can and if anyone has done that in the past, it's probably me.) PR-URL: #39181 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eb2d75d - Browse repository at this point
Copy the full SHA eb2d75dView commit details -
doc: remove instructions for unsupported Node.js versions
Remove special V8 maintenance instructions for versions of Node.js prior to 9.0.0. Perform other minor edits in nearby text. PR-URL: #39185 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Configuration menu - View commit details
-
Copy full SHA for 52105ac - Browse repository at this point
Copy the full SHA 52105acView commit details -
doc: add cc oss-security@lists.openwall.com
This commit adds step to CC oss-security@lists.openwall.com as part of the security release process. PR-URL: #39191 Refs: nodejs/TSC#1047 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for fa39095 - Browse repository at this point
Copy the full SHA fa39095View commit details -
doc: use ASCII order for md refs
PR-URL: #39170 Refs: nodejs/remark-preset-lint-node#188 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2f6861c - Browse repository at this point
Copy the full SHA 2f6861cView commit details -
tools: update remark-preset-lint-node to 2.4.1
PR-URL: #39201 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3ecfe9d - Browse repository at this point
Copy the full SHA 3ecfe9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a2ce5d - Browse repository at this point
Copy the full SHA 8a2ce5dView commit details -
esm: deprecate legacy main lookup for modules
PR-URL: #36918 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e73bfed - Browse repository at this point
Copy the full SHA e73bfedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7378b84 - Browse repository at this point
Copy the full SHA 7378b84View commit details -
esm: update to correct deprecation code
#36918 landed with references to DEP0150, which is already used for a different deprecation. This commit updates the code to use DEP0151. PR-URL: #37147 Refs: #36918 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9db3304 - Browse repository at this point
Copy the full SHA 9db3304View commit details -
doc,lib: prepare for stricter multi-line array linting
We're about to turn on a requirement for dangling commas. PR-URL: #37088 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d56e826 - Browse repository at this point
Copy the full SHA d56e826View commit details -
tools: make comma-dangle ESLint rule more stringent …
We've been having a lot of nits lately asking people to add trailing commas, so it's probably time to incrementally make the comma-dangle rule more stringent. PR-URL: #37088 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 315eba7 - Browse repository at this point
Copy the full SHA 315eba7View commit details -
test: prepare for consistent comma-dangle lint rule
Make changes so that tests will pass when the comma-dangle settings applied to the rest of the code base are also applied to tests. PR-URL: #37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Configuration menu - View commit details
-
Copy full SHA for a2e4020 - Browse repository at this point
Copy the full SHA a2e4020View commit details -
tools: apply consistent comma-dangle lint rule
Use comma-dangle settings from the rest of the code base on tests as well. PR-URL: #37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Configuration menu - View commit details
-
Copy full SHA for e7761b6 - Browse repository at this point
Copy the full SHA e7761b6View commit details -
repl: fix Ctrl+C on top level await
PR-URL: #38656 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 761dafa - Browse repository at this point
Copy the full SHA 761dafaView commit details -
repl: ensure correct syntax err for await parsing
PR-URL: #39154 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 9966449 - Browse repository at this point
Copy the full SHA 9966449View commit details -
doc: move vm.measureMemory() to expected location in doc
PR-URL: #39211 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bd6af78 - Browse repository at this point
Copy the full SHA bd6af78View commit details -
doc: move v8.stopCoverage() to expected location in doc
PR-URL: #39212 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0d098bf - Browse repository at this point
Copy the full SHA 0d098bfView commit details -
doc: use "pull request" instead of "PR" in packages.md
PR-URL: #39213 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c4a3a24 - Browse repository at this point
Copy the full SHA c4a3a24View commit details -
Thinking it is probably better to run this frequently and do small quick timely updates to AUTHORS rather than waiting months like we usually do and having a lot of little issues to sort out. If this works well, maybe it can be a scheduled GitHub Action or something the bot does for us. PR-URL: #39217 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for c97ebd7 - Browse repository at this point
Copy the full SHA c97ebd7View commit details -
doc: use more consistent formatting for deprecations
Most deprecations do not end with a full-stop/period, but three of them do. Well, not anymore after this change. PR-URL: #39218 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9c7c447 - Browse repository at this point
Copy the full SHA 9c7c447View commit details -
tools: remove unused
lint-pr-commit-message.sh
`tools/lint-pr-commit-message.sh` was previously used to lint the commit message of the first commit in a pull request but is now no longer used -- commit message linting is now done in a GitHub actions workflow which does not call this script. PR-URL: #39120 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b8fb751 - Browse repository at this point
Copy the full SHA b8fb751View commit details -
doc: normalize CSS variable names and indentation
PR-URL: #39199 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fdd3159 - Browse repository at this point
Copy the full SHA fdd3159View commit details -
doc: rename datatypes to data types
PR-URL: #39209 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c6118b2 - Browse repository at this point
Copy the full SHA c6118b2View commit details -
meta: add @nodejs/actions as CODEOWNERS
PR-URL: #39119 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9766a99 - Browse repository at this point
Copy the full SHA 9766a99View commit details -
tools: update path-parse to 1.0.7
path-parse 1.0.6 is vulnerable to ReDoS. Update to 1.0.7. Uh, not that a ReDoS is likely to affect us in this tool. Refs: jbgutierrez/path-parse@09e1086 PR-URL: #39232 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ff0ca11 - Browse repository at this point
Copy the full SHA ff0ca11View commit details -
test: move test-debugger-address to parallel
The test uses `--inspect=0` so it uses an OS-selected port rather than the default port. This means it can be run in the parallel directory. PR-URL: #39236 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2cd4141 - Browse repository at this point
Copy the full SHA 2cd4141View commit details -
doc: fix color contrast for anchor marks in dark mode
Currently, in its dark mode, our website background color is #090C15 and our anchor marks are #707070 for a contrast ratio of 3.94 to 1, falling short of the WCAG AA 4.5 to 1. This changes the mark color in dark mode only to #7A7A7A for a color contrast of 4.55 to 1. PR-URL: #39168 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9178805 - Browse repository at this point
Copy the full SHA 9178805View commit details -
node-api: cctest on v8impl::Reference
PR-URL: #38970 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9e5edf2 - Browse repository at this point
Copy the full SHA 9e5edf2View commit details -
repl: processTopLevelAwait fallback error handling
PR-URL: #39290 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1e065a0 - Browse repository at this point
Copy the full SHA 1e065a0View commit details -
readline: allow completer to rewrite existing input
Sometimes, it makes sense for a completer to change the existing input, e.g. by adjusting the casing (imagine a completer that corrects `Number.isNan` to `Number.IsNaN`, for example). This commit allows that in the readline implemention. PR-URL: #39178 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 6c87b59 - Browse repository at this point
Copy the full SHA 6c87b59View commit details -
meta: use form schema for bug report template
PR-URL: #39194 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2f325c9 - Browse repository at this point
Copy the full SHA 2f325c9View commit details -
PR-URL: #39250 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 06acbf6 - Browse repository at this point
Copy the full SHA 06acbf6View commit details -
doc: move Sam Ruby to emeritus
Sam confirmed in email that they are not opposed to moving to emeritus at this time. PR-URL: #39264 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Configuration menu - View commit details
-
Copy full SHA for 6466faf - Browse repository at this point
Copy the full SHA 6466fafView commit details -
Migrate last bit of onboarding-extras content to collaborator-guide and remove onboarding-extras. PR-URL: #39252 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f08e9d5 - Browse repository at this point
Copy the full SHA f08e9d5View commit details -
doc: update node-api support matrix
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #38424 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9357547 - Browse repository at this point
Copy the full SHA 9357547View commit details -
doc: update Node-api version matrix
- add 14.x version in which Node-api version 8 was added. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #39197 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 31163ed - Browse repository at this point
Copy the full SHA 31163edView commit details -
build: shorten path used in tarball build workflow
Shorten the path to the workspace for the GitHub Actions `build-tarball` workflow to avoid `execvp: printf: Argument list too long` errors from `make`. GitHub currently runs workflows in a `/home/runner/work/my-repo/my-repo` directory where `my-repo` is the repository name and is repeated twice (the second is from the git checkout). Some of the command lines in the Node.js build, e.g. the `ar` command to create static libraries, pass several fully qualified paths to filenames so the workflow directory is repeat many times. The most recent V8 update added more files to the command and has now tipped the command line length over the maximum allowed when using forks of the `node` repository with a longer name (e.g. `node-auto-test` and the private fork used to prepare security releases). Use GitHub's `RUNNER_TEMP` environment variable to extract the source tarball into the temporary directory on the GitHub runner. This is currently `/home/runner/work/_temp` and is not dependent on the name of the repository. PR-URL: #39192 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5c6ab71 - Browse repository at this point
Copy the full SHA 5c6ab71View commit details -
test: remove workaround code in debugger test
Remove code that made a check more lenient to account for a known issue that is no longer reproducible. Refs: nodejs/node-inspect#35 PR-URL: #39238 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6852389 - Browse repository at this point
Copy the full SHA 6852389View commit details -
doc: use "repository" in guides versus repo
Fix remaining instances in the guides where we use repo instead of repository. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #39198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for a4d70ff - Browse repository at this point
Copy the full SHA a4d70ffView commit details -
Added JSDoc typings for the `v8` lib module. PR-URL: #38944 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 41213bd - Browse repository at this point
Copy the full SHA 41213bdView commit details -
doc: remove emailing the TSC from offboarding doc
Emailing the TSC seems superfluous. Removing it. PR-URL: #39280 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for b4a0c5a - Browse repository at this point
Copy the full SHA b4a0c5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40e4632 - Browse repository at this point
Copy the full SHA 40e4632View commit details -
Judging from https://github.com/logos, we are misusing the GitHub mark. That page indicates to not change the color (we change it from black to green). Less clear, it says "Use the Mark in social buttons to link to your GitHub profile or project" which isn't exactly what we're doing but also isn't not what we're doing? This might be an indication of my eyesight getting worse as I get older, but I think the size that we display the mark at by default makes it not entirely recognizable as the GitHub mark. Lastly, there's the philosophical issue of whether we should display a commercial entity's mark on our web pages in this particular instance. (For me, the answer is "maybe".) All told, I think we can remove it without damaging usability on the website, so let's do it. PR-URL: #39251 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8c569ce - Browse repository at this point
Copy the full SHA 8c569ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b737eb - Browse repository at this point
Copy the full SHA 9b737ebView commit details -
doc: update collaborator email address
PR-URL: #39263 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for f46ae3f - Browse repository at this point
Copy the full SHA f46ae3fView commit details -
tools: add find-inactive-collaborators.js
The plan is to eventually call this script with a scheduled GitHub Action that could automatically open pull requests to move collaborators to emeritus status after (for example) a year of inactivity. Sample run: ``` $ node tools/find-inactive-collaborators.mjs '30 months ago' 864 authors have made commits since 30 months ago. 101 landers have landed commits since 30 months ago. 146 reviewers have approved landed commits since 30 months ago. 109 collaborators currently in the project. Inactive collaborators: Thomas Watson $ ``` PR-URL: #39262 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 61ec594 - Browse repository at this point
Copy the full SHA 61ec594View commit details -
doc: use "repository" instead of "repo" in onboarding.md
PR-URL: #39286 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 22f0b7e - Browse repository at this point
Copy the full SHA 22f0b7eView commit details -
doc: simplify CRAN mirror text in benchmark guide
PR-URL: #39287 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fc7d714 - Browse repository at this point
Copy the full SHA fc7d714View commit details -
doc: move ofrobots to collaborator emeritus
Ali indicated in email that it makes sense to move him to collaborator emeritus at this time. PR-URL: #39307 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Configuration menu - View commit details
-
Copy full SHA for fbf658f - Browse repository at this point
Copy the full SHA fbf658fView commit details -
repl: correctly hoist top level await declarations
PR-URL: #39265 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 50c5e71 - Browse repository at this point
Copy the full SHA 50c5e71View commit details -
doc: move AndreasMadsen to emeritus
In private email, Andreas Madsen indicated it would be OK to move him to emeritus. PR-URL: #39315 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5eafc3a - Browse repository at this point
Copy the full SHA 5eafc3aView commit details -
tools: pass bot token to node-pr-labeler
This should allow workflows that use the `labeled` event to be run. PR-URL: #39271 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for f467e2a - Browse repository at this point
Copy the full SHA f467e2aView commit details -
test: use common.PORT instead of hardcoded port number
PR-URL: #39298 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a45bf2f - Browse repository at this point
Copy the full SHA a45bf2fView commit details -
debugger: prevent simultaneous heap snapshots
Fixes: #39555 PR-URL: #39638 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b3352cf - Browse repository at this point
Copy the full SHA b3352cfView commit details -
test: fix test-debugger-heap-profiler for workers
Fix `sequential/test-debugger-heap-profiler` so that it can be run in a worker thread. `process.chdir()` is not allowed in worker threads but passing a current working directory into a spawned child process is allowed. PR-URL: #39687 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e12164e - Browse repository at this point
Copy the full SHA e12164eView commit details -
debugger: rename inspector-cli test module to debugger
PR-URL: #38530 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 72a3419 - Browse repository at this point
Copy the full SHA 72a3419View commit details -
test: remove debugger workaround for AIX
Optimistically removing workaround code in the debugger test tool. PR-URL: #39296 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5462023 - Browse repository at this point
Copy the full SHA 5462023View commit details -
test: move debugger test case to parallel
Move test case that does not require a predetermined port to parallel. PR-URL: #39300 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Configuration menu - View commit details
-
Copy full SHA for 1eb8307 - Browse repository at this point
Copy the full SHA 1eb8307View commit details -
test: remove eslint-disable comment from fixture file
Fixtures are not linted so eslint-disable comments are unnecessary. PR-URL: #39320 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c915a1b - Browse repository at this point
Copy the full SHA c915a1bView commit details -
typings: add JSDoc typings for timers
Added JSDoc typings for the `timers` lib module. PR-URL: #38834 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for d458cd7 - Browse repository at this point
Copy the full SHA d458cd7View commit details -
build: remove unused comment in Makefile
PR-URL: #39171 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 131dd6e - Browse repository at this point
Copy the full SHA 131dd6eView commit details -
tools,doc: fix error message for unrecognized type
PR-URL: #39221 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 87e5429 - Browse repository at this point
Copy the full SHA 87e5429View commit details -
doc: put information about the past in details tags
To make the README more scannable and keep it manageable in length, put emeriti and past keys lists in details tags. PR-URL: #39321 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b47b479 - Browse repository at this point
Copy the full SHA b47b479View commit details -
typings: add a few JSDoc typings for the net lib module
PR-URL: #38953 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for f206af6 - Browse repository at this point
Copy the full SHA f206af6View commit details -
build: update gcovr for gcc 8 compatibility
Update the version of `gcovr` used for C++ coverage from 3.4 to 4.2 for compatibility with gcc/g++ 8. PR-URL: #39326 Refs: #39303 Refs: gcovr/gcovr#228 Refs: nodejs/build#2705 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f2e1c22 - Browse repository at this point
Copy the full SHA f2e1c22View commit details -
tools: relax max-len lint rule for template strings
Splitting template strings across multiple lines can make them harder to read. PR-URL: #38097 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d86d37b - Browse repository at this point
Copy the full SHA d86d37bView commit details -
tools: add GitHub Action to run find-inactive-collaborators.mjs
Add a GitHub Action for find-inactive-collaborators.mjs that will run it and list collaborators who have been inactive for more than a year. It will run when manually triggered by a collaborator and on a schedule of once a month. PR-URL: #39335 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for edc5791 - Browse repository at this point
Copy the full SHA edc5791View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49e0883 - Browse repository at this point
Copy the full SHA 49e0883View commit details -
PR-URL: #39277 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 25c104f - Browse repository at this point
Copy the full SHA 25c104fView commit details -
doc: do not use & for "and" in text
This also changes a line in the man page to be sentence case. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/special-characters PR-URL: #39345 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9d43ce3 - Browse repository at this point
Copy the full SHA 9d43ce3View commit details -
doc: add text about moving long commit lists out of PR description
PR-URL: #39186 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 6f0b3a2 - Browse repository at this point
Copy the full SHA 6f0b3a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8066f5 - Browse repository at this point
Copy the full SHA d8066f5View commit details -
doc: edit guide on pull requests
* Replace _PR_ with Pull Request * Make some content more concise PR-URL: #39359 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0b1ce72 - Browse repository at this point
Copy the full SHA 0b1ce72View commit details -
test: put common lint exceptions into config file
For lint exceptions that are universal or near universal for `test/common`, put the exceptions in a config file rather than disabling the ESLint rules at the top of each file. PR-URL: #39358 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 831f266 - Browse repository at this point
Copy the full SHA 831f266View commit details -
tools: use Node.js 16.x for GitHub workflow
find-inactive-collaborators.mjs works fine with Node.js 16.x, but GitHub Actions currently use 14.x by default. PR-URL: #39362 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d948148 - Browse repository at this point
Copy the full SHA d948148View commit details -
tools: change commit fetch limiting in find-inactive-collaborators
GitHub Action workflows can be told to clone a certain number of commits or else everything. Change find-inactive-collaborators to take a number of commits to examine rather than a date range so that the parameter can be used in GitHub Actions. PR-URL: #39362 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cec0482 - Browse repository at this point
Copy the full SHA cec0482View commit details -
In email, John-David Dalton confirmed that it was appropriate to move to emeritus at this time. PR-URL: #39380 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f39d93a - Browse repository at this point
Copy the full SHA f39d93aView commit details -
src: remove unused guards around node-api reference
PR-URL: #38334 Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 5c473bd - Browse repository at this point
Copy the full SHA 5c473bdView commit details -
build: update to setup-node@v2
commit-lint.yml uses setup-node@v1 but all our other GitHub Actions use v2. Update commit-lint.yml. PR-URL: #39366 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0da5d74 - Browse repository at this point
Copy the full SHA 0da5d74View commit details -
PR-URL: #39367 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for baaa397 - Browse repository at this point
Copy the full SHA baaa397View commit details -
process: add api to enable source-maps programmatically
Add `process.setSourceMapsEnabled` to enable source-maps programmatically. PR-URL: #39085 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1a6bf1c - Browse repository at this point
Copy the full SHA 1a6bf1cView commit details -
doc: update mailmap and deduplicate AUTHORS entry
PR-URL: #39391 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 672023f - Browse repository at this point
Copy the full SHA 672023fView commit details -
debugger: rename internal module
All other files in `lib/internal` do not start with `_`. For consistency, move `lib/internal/debugger/_inspect.js` to `lib/internal/debugger/inspect.js`. PR-URL: #39378 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e9c4610 - Browse repository at this point
Copy the full SHA e9c4610View commit details -
doc: standardize on not capitalizing _collaborator_
Sometimes we capitalize _collaborator_ and sometimes not. After consulting the Microsoft Style Guide and The Chicago Manual of Style, I've concluded it is best to not capitalize it. For consistency, apply that to our various .md files. Refs: https://docs.microsoft.com/en-us/style-guide/capitalization PR-URL: #39379 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c3cfefc - Browse repository at this point
Copy the full SHA c3cfefcView commit details -
doc: add instructions for core vuln files
This commit adds instructions for adding machine-readable json files to the security-wg repo in the security release guide. PR-URL: #39220 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8438e8b - Browse repository at this point
Copy the full SHA 8438e8bView commit details -
doc: add docker-node and build-wg issue contents
This commit add the contents that should go into the docker-node and build issues when doing a security release. PR-URL: #39215 Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for ab0bf4f - Browse repository at this point
Copy the full SHA ab0bf4fView commit details -
doc: make minor edits to pull request text
PR-URL: #39383 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eb12e4c - Browse repository at this point
Copy the full SHA eb12e4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c93968 - Browse repository at this point
Copy the full SHA 4c93968View commit details -
doc: standardize on _pull request_
Sometimes we capitalize _pull request_ and sometimes we don't. Standardize on lowercase based on Microsoft Style Guide, Chicago Manual of Style, and GitHub's own docs and UI. Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request Refs: https://docs.microsoft.com/en-us/style-guide/capitalization PR-URL: #39384 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1a494d5 - Browse repository at this point
Copy the full SHA 1a494d5View commit details -
doc: add strategic initiatives from TSC repo
This (along with a corresponding PR for the TSC repo) moves the strategic initiatives from the TSC repository to the main core repo. This will increase visibility for strategic initiatives. It will also facilitate the proposed reduced centrality of TSC champions to strategic plans. In the process, I made the text less wordy. I moved the Build Resources initiatve out of the active list, as discussed at the most recent TSC meeting. I alphabetized the table entries. (Chronological order isn't obvious to a reader if no dates are provided.) Refs: nodejs/TSC#962 (comment) PR-URL: #39394 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 73f784f - Browse repository at this point
Copy the full SHA 73f784fView commit details -
doc: use _pull request_ instead of _PR_ in onboarding doc
PR-URL: #39409 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 63b0603 - Browse repository at this point
Copy the full SHA 63b0603View commit details -
doc: update commit-queue.md to indicate GitHub Actions are checked
Refs: #39384 (comment) PR-URL: #39411 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 43d28f5 - Browse repository at this point
Copy the full SHA 43d28f5View commit details -
debugger: validate sec-websocket-accept response header
This addresses a TODO to validate that the sec-websocket-accept header in the WebSocket handshake response is valid. To do this we need to append the WebSocket GUID to the original key sent in sec-websocket-key, sha1 hash it, and then compare the base64 encoding with the value sent in the sec-websocket-accept response header. If they don't match, an error is thrown. PR-URL: #39357 Refs: nodejs/node-inspect#93 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 482459e - Browse repository at this point
Copy the full SHA 482459eView commit details -
test: add test for WebSocket secret verification in debugger
PR-URL: #39357 Refs: nodejs/node-inspect#93 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0b564a6 - Browse repository at this point
Copy the full SHA 0b564a6View commit details -
doc: use a details tag for completed initiatves
The list of completed initiatives is longer and visually more noticeable than the list of current initiatives, but the current initiatives are likely the ones of interest. The completed initiatives list is only going to get longer and longer, so let's put it in a details tag. PR-URL: #39416 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 8376b07 - Browse repository at this point
Copy the full SHA 8376b07View commit details -
build: run workflows when a PR is ready for review
Add `ready_for_review` to the activity types for the pull_request event. PR-URL: #39405 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4e28d2b - Browse repository at this point
Copy the full SHA 4e28d2bView commit details -
doc: update mailmap and AUTHORS
Based on their GitHub and other social media profiles as well as the most recent of their authored commits, I suspect watson goes by "Thomas Watson" and not the name currently listed in the .mailmap and AUTHORS files. Update. I'm doing this because it helps avoid false positives in `find-inactive-collaborators.mjs` which uses `git shortlog` which uses `.mailmap`. PR-URL: #39393 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cd8e773 - Browse repository at this point
Copy the full SHA cd8e773View commit details -
doc: revise strategic initiatives text
Now that it's in the core repo, so ome of the TSC-centric text doesn't make as much sense as it did when it was in the TSC repo. PR-URL: #39417 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 86e1260 - Browse repository at this point
Copy the full SHA 86e1260View commit details -
doc: remove outdated step in onboarding exercise
The GitHub bot will leave a comment asking people to thumbs-up a fast track request so there is no need to manually leave such a comment. PR-URL: #39410 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ca947ac - Browse repository at this point
Copy the full SHA ca947acView commit details -
doc: fix broken internal link in http.md
PR-URL: #39425 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a3dee70 - Browse repository at this point
Copy the full SHA a3dee70View commit details -
meta: add .mailmap entry for new email for existing contributor
PR-URL: #39431 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 69b56a3 - Browse repository at this point
Copy the full SHA 69b56a3View commit details -
We have a few cases in .mailmap where multiple entries are used where a single one would do. Consolidate those entries. PR-URL: #39418 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ae97a96 - Browse repository at this point
Copy the full SHA ae97a96View commit details -
The module has been there for a while, evidence of usage in the field exists, and we have good test coverage for it. Last API change has been 18 months ago. Refs: #37440 (comment) PR-URL: #37748 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1e5aca5 - Browse repository at this point
Copy the full SHA 1e5aca5View commit details -
tools: added remark-frontmatter
remark-frontmatter allows the use of frontmatter metadata in markdown files PR-URL: #38717 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Configuration menu - View commit details
-
Copy full SHA for d2c0da2 - Browse repository at this point
Copy the full SHA d2c0da2View commit details -
build: update coverage Makefile target comments
Update the comments for the `coverage` Makefile target. - Source files under `lib` are no longer instrumented since d1dee49 - Fix the name of the related CI job. PR-URL: #39365 Refs: #25157 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6e06b2f - Browse repository at this point
Copy the full SHA 6e06b2fView commit details -
doc: remove _Addenda_ from headers
PR-URL: #39427 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d17afa0 - Browse repository at this point
Copy the full SHA d17afa0View commit details -
doc: update checkbox label in backporting guide
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #39420 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6a4c6ce - Browse repository at this point
Copy the full SHA 6a4c6ceView commit details -
tools: make internal link checker more robust
The internal link checker was missing some broken links because it was being too restrictive about the characters it accepted as part of a link hash. Accept anything that isn't a terminating quotation mark. Refs: #39426 Refs: #39425 PR-URL: #39429 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Configuration menu - View commit details
-
Copy full SHA for dfb77a5 - Browse repository at this point
Copy the full SHA dfb77a5View commit details -
tools: email matchin is case insensitive for .mailmap
PR-URL: #39430 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f75224f - Browse repository at this point
Copy the full SHA f75224fView commit details -
doc: simplify unnecessarily specific .mailmap entries
PR-URL: #39430 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 39da842 - Browse repository at this point
Copy the full SHA 39da842View commit details -
tools: use mailmap for find-inactive-collaborators
The current version of find-inactive-collaborators can generate a false positive if the mailmap entry for a collaborator does not match the entry in the README. (We should probably lint or otherwise check for that sort of mismatch but regardless, it is relatively easy to avoid having find-inactive-collaborators tripped up by it, so let's fix that too, which is this commit.) PR-URL: #39432 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 87c5332 - Browse repository at this point
Copy the full SHA 87c5332View commit details -
doc,meta: update email addresses for misterdjules
Julien Gilli appears twice with two email addresses in the current AUTHORS file. Use .mailmap to map one to the other (keeping the most recent one). Also update email in the README from a (I believe invalid, since it is not listed in the email repo aliases.json file) nodejs.org email to the email they more recently committed with. Finally, re-run `update-authors.js` so they only have one entry in AUTHORS. PR-URL: #39433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ab66dab - Browse repository at this point
Copy the full SHA ab66dabView commit details -
deps: bump HdrHistogram_C to 0.11.2
Release tag: https://github.com/HdrHistogram/HdrHistogram_c/releases/tag/0.11.2 Fixes: #39450 PR-URL: #39462 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d863a9d - Browse repository at this point
Copy the full SHA d863a9dView commit details -
src: close HandleWraps instead of deleting them in OnGCCollect()
When all strong `BaseObjectPtr`s to a `HandleWrap` are gone, we should not delete the `HandleWrap` outright, but instead close it and then delete it only once the libuv close callback has been called. Based on the valgrind output from the issue below, this has a good chance of fixing it. Fixes: #39036 PR-URL: #39441 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e6ff7e6 - Browse repository at this point
Copy the full SHA e6ff7e6View commit details -
PR-URL: #39461 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 83f5cc0 - Browse repository at this point
Copy the full SHA 83f5cc0View commit details -
src: print native module id on native module not found
To help core contributors identify which file is missing from the build. PR-URL: #39460 Refs: #39408 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 985ec48 - Browse repository at this point
Copy the full SHA 985ec48View commit details -
doc,tools: remove
checkLinks.mjs
The checks made by this are now integrated to `remark-preset-lint-node`, there are no reason to keep it around anymore. PR-URL: #39206 Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c6ccd97 - Browse repository at this point
Copy the full SHA c6ccd97View commit details -
tools: flag README/mailmap mismatches in find-inactive-collaborators
PR-URL: #39477 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for a5152a0 - Browse repository at this point
Copy the full SHA a5152a0View commit details -
meta: align collaborator email in .mailmap/AUTHORS with README
Use the most recent and presumably preferred email for a collaborator whose .mailmap and README entries differ. PR-URL: #39478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 55322c0 - Browse repository at this point
Copy the full SHA 55322c0View commit details -
meta: alphabetize .mailmap file
The file is mostly sorted in lexical order but there are exceptins, a few of them significant. This puts everything in lexical order. PR-URL: #39434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1302a91 - Browse repository at this point
Copy the full SHA 1302a91View commit details -
meta: revise .mailmap for README consistency
Update entry in .mailmap to reflect the same entry in README for an existing collaborator. PR-URL: #39457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2f816bf - Browse repository at this point
Copy the full SHA 2f816bfView commit details -
meta: align email address in README/.mailmap/AUTHORS
Modify .mailmap so Myles has the same email address in AUTHORS as he does in README. PR-URL: #39503 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 1b2078c - Browse repository at this point
Copy the full SHA 1b2078cView commit details -
meta: align collaborator name in .mailmap/AUTHORS with README
I exchanged email with Gerhard to make sure that this was the rendering of his name that was correct. PR-URL: #39489 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 5f49352 - Browse repository at this point
Copy the full SHA 5f49352View commit details -
doc: update strategic initiative champion
This change was discussed at the TSC meeting today. PR-URL: #39487 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e826109 - Browse repository at this point
Copy the full SHA e826109View commit details -
PR-URL: #39488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for c7523da - Browse repository at this point
Copy the full SHA c7523daView commit details -
doc: move lball@redhat.com to emeritus
I have not contributed to Node.js in a couple of years. While I would love to continue doing so, there's not a high likelihood of this happening in the near future. This commit moves my status from collaborator to emeritus. It's been fun! Signed-off-by: Lance Ball <lball@redhat.com> PR-URL: #39501 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 695569f - Browse repository at this point
Copy the full SHA 695569fView commit details -
events: allow the options argument to be null
Make `EventTarget.prototype.addEventListener()` accept `null` as a valid value for the `options` argument. PR-URL: #39486 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Configuration menu - View commit details
-
Copy full SHA for c1782ea - Browse repository at this point
Copy the full SHA c1782eaView commit details -
The WASI link test attempts to create a link in the temporary directory to a file in the fixtures directory and can fail if those directories are on different devices. Update the test so that both the source and target of the link reside on the same device. PR-URL: #39485 Fixes: #39484 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5696bcf - Browse repository at this point
Copy the full SHA 5696bcfView commit details -
build: fix
host_arch_cc()
for AIX/IBM iThe AIX/IBM i branch in `host_arch_cc()` that hardcodes the compiler executable to `gcc` precludes picking up either `CC_host` or `CC` environment variables (if set) as is done on other platforms. On an AIX/IBM i platform where the compiler is, e.g. `gcc-10` instead of just `gcc`, the current check will fail to detect the host architecture and incorrectly default to `ia32`. Removing the AIX/IBM i specific branch will follow the same logic as on the other platforms: 1. The value, if set, of the `CC_host` environment variable. 2. Otherwise, if set, the value of the `CC` environment variable. 3. `gcc` (`cc` if on macOS). PR-URL: #39481 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 719f156 - Browse repository at this point
Copy the full SHA 719f156View commit details -
meta: update email address for collaborator
In email, Saúl indicated that they've switched to using their personalized domain email address. Update their email in README accordingly. This will align their email in the README with their email in .mailmap, which will in turn assist the accuracy of tools for contributor metrics. PR-URL: #39511 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b0c1aab - Browse repository at this point
Copy the full SHA b0c1aabView commit details -
meta: remove unneeded .mailmap entry
The previous Perl script used to generate the AUTHORS file (probably) needed more entries than the current JS script to avoid duplicate entries in AUTHORS. The entry removed here is no longer needed for that purpose, but it is creating a small issue around tooling for gathering contributor metrics. PR-URL: #39512 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f269df3 - Browse repository at this point
Copy the full SHA f269df3View commit details -
meta: update collaborator email in README
Per instructions from Fedor, I'm updating their email address in the README. PR-URL: #39510 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 48ec33f - Browse repository at this point
Copy the full SHA 48ec33fView commit details -
build: use Node.js 14 in commit-lint.yml
All of our workflows use Node.js 14.x or 16.x except for commit-lint.yml which has 12.x hard-coded. Update it to 14.x and change it to using an environment variable so it is consistent with our other workflows. PR-URL: #39506 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 61261cd - Browse repository at this point
Copy the full SHA 61261cdView commit details -
zlib: avoid converting
Uint8Array
instances toBuffer
PR-URL: #39492 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 61b4a98 - Browse repository at this point
Copy the full SHA 61b4a98View commit details -
build: override python executable path on configure
PR-URL: #39465 Fixes: #39408 Fixes: #39456 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3482bca - Browse repository at this point
Copy the full SHA 3482bcaView commit details -
repl: do not include legacy getter/setter methods in completion
For every object that inherits from `Object.prototype`, the REPL includes the `Object.prototype` methods in its autocompletion. This is already a little noisy, but in particular, this also includes the legacy `__defineGetter__` family of methods; since those are deprecated and not in practical use anymore, it helps reduce noise a bit to remove them. This commit does not remove `__proto__` as it is a little more popular and, despite its downsides, a slightly more convenient way to access the prototype of an object in the REPL than `Object.getPrototypeOf(...)`. PR-URL: #39576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9264cae - Browse repository at this point
Copy the full SHA 9264caeView commit details -
George does not appear to be active in Node.js for quite some time (correction welcome!) and my attempts to get in touch have failed. PR-URL: #39539 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: George Adams <george.adams@microsoft.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for fbecae1 - Browse repository at this point
Copy the full SHA fbecae1View commit details -
meta: update collaborator email in AUTHORS/.mailmap
Update email for Zeyu Yang. PR-URL: #39521 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5e1c49f - Browse repository at this point
Copy the full SHA 5e1c49fView commit details -
meta: update collaborator email in README
Update email for Shelley Vohr to correspond to what is specified in .mailmap and what is used in more recently authored commits. PR-URL: #39521 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 27e9a44 - Browse repository at this point
Copy the full SHA 27e9a44View commit details -
meta: update collaborator email in AUTHORS/.mailmap
Update email for Ujjwal Sharma. PR-URL: #39521 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fdcc572 - Browse repository at this point
Copy the full SHA fdcc572View commit details -
doc: add code example to
http.createServer
methodPR-URL: #39455 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a437de3 - Browse repository at this point
Copy the full SHA a437de3View commit details -
http: decodes url.username and url.password for authorization header
This change properly decodes the url.username and url.password for the authorization header constructed from the URL object for http(s) requests. Fixes: #31439 PR-URL: #39310 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2bc301d - Browse repository at this point
Copy the full SHA 2bc301dView commit details -
src: add cosmetic space character to
async_wrap.h
filePR-URL: #39459 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 495cd02 - Browse repository at this point
Copy the full SHA 495cd02View commit details -
build: use lts shorthand in GitHub Actions
Rather than hard-coding GitHub Actions to use Node.js 14.x, use the `lts/*` shorthand for "most recent LTS version". PR-URL: #39538 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0bd6dd1 - Browse repository at this point
Copy the full SHA 0bd6dd1View commit details -
meta: add .mailmap entry to remove duplication in AUTHORS
PR-URL: #39559 Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1755f49 - Browse repository at this point
Copy the full SHA 1755f49View commit details -
doc: update backport labels in release guide
Add `backport-open-v1.x,backported-to-v1.x` labels to `branch-diff` commands as these indicate pull requests that are being manually backported and should not be cherry-picked. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 42669bb - Browse repository at this point
Copy the full SHA 42669bbView commit details -
doc: fence command examples in release guide
Put the command examples for finding and replacing the `REPLACEME` tags into code fences so that they are more easily copiable when viewing the guide in the GitHub web UI. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a718b26 - Browse repository at this point
Copy the full SHA a718b26View commit details -
doc: remove outdated ARM information from release guide
We no longer produced ARMv6 builds, and the ARMv7 builds are now cross compiled and are as quick as builds on the other platforms. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 89c8afc - Browse repository at this point
Copy the full SHA 89c8afcView commit details -
doc: move
NODE_MODULE_VERSION
in release guideMove the section on `NODE_MODULE_VERSION` into the section for major releases as it should only be updated for a major release. Add a note to remove the `-pre` suffix from the registry for the release commit. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8799a13 - Browse repository at this point
Copy the full SHA 8799a13View commit details -
meta: add .mailmap entries to remove AUTHORS duplicates
PR-URL: #39560 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6c4febd - Browse repository at this point
Copy the full SHA 6c4febdView commit details -
meta: update .mailmap to remove duplication in AUTHORS
PR-URL: #39561 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2d64286 - Browse repository at this point
Copy the full SHA 2d64286View commit details -
doc: add code examples to
Writable.destroy()
andWritable.destroyed
PR-URL: #39491 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 48281ec - Browse repository at this point
Copy the full SHA 48281ecView commit details -
PR-URL: #39587 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 1fbc19e - Browse repository at this point
Copy the full SHA 1fbc19eView commit details -
meta: add mailmap entry for ttzztztz
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0833e2d - Browse repository at this point
Copy the full SHA 0833e2dView commit details -
meta: add mailmap entry for garygsc
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fd2146b - Browse repository at this point
Copy the full SHA fd2146bView commit details -
build: exclude markdown files from some GitHub Actions
Ignore all markdown files when determining if test-asan, coverage-*, and test-macos need to run. Refs: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#patterns-to-match-file-paths PR-URL: #39565 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for c696f97 - Browse repository at this point
Copy the full SHA c696f97View commit details -
meta: align README/.mailmap/AUTHORS email entries
The email address for Weijia Wang in the AUTHORS and .mailmap files is different from the email address in the README.md file. Based on their GitHub profile and commit metadata, the one in the README.md file is the preferred email. Updating .mailmap and AUTHORS to reflect it. PR-URL: #39505 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
Configuration menu - View commit details
-
Copy full SHA for 030036e - Browse repository at this point
Copy the full SHA 030036eView commit details -
debugger: remove undefined parameter
The data parameter of unpackError() is typically undefined. PR-URL: #39570 Refs: https://github.com/nodejs/node-inspect/issues/101 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for f46e8cd - Browse repository at this point
Copy the full SHA f46e8cdView commit details -
test: add test-debugger-breakpoint-exists
This adds test coverage to `unpackError()` in `lib/internal/debugger/inspect_client.js`. That function previously was untested. PR-URL: #39570 Refs: https://github.com/nodejs/node-inspect/issues/101 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 78db43c - Browse repository at this point
Copy the full SHA 78db43cView commit details -
test: convert anonymous function to arrow function
PR-URL: #39604 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 68ef265 - Browse repository at this point
Copy the full SHA 68ef265View commit details -
meta: add mailmap entry for dmabupt
This consolidates two email addresses/entries in AUTHORS into one. PR-URL: #39596 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a2d8eb - Browse repository at this point
Copy the full SHA 2a2d8ebView commit details -
meta: add mailmap entry for uttampawar
This consolidates two email addresses/entries in AUTHORS into one. PR-URL: #39596 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ae3f8b1 - Browse repository at this point
Copy the full SHA ae3f8b1View commit details -
meta: add mailmap entry for ryzokuken
This consolidates two email addresses/entries in AUTHORS into one. PR-URL: #39596 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 472cf15 - Browse repository at this point
Copy the full SHA 472cf15View commit details -
test: deflake test-http2-buffersize
This is basically a revert of c452632. The problem with that commit is that the promises returned by `once(server, 'stream')` are all resolved with the same stream when the first `'stream'` event is emitted. Refs: #39525 (comment) PR-URL: #39591 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for a610760 - Browse repository at this point
Copy the full SHA a610760View commit details -
PR-URL: #39629 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b9f2ea9 - Browse repository at this point
Copy the full SHA b9f2ea9View commit details -
meta: consolidate emails for timruffles
PR-URL: #39611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fdbe978 - Browse repository at this point
Copy the full SHA fdbe978View commit details -
meta: consolidate emails for timcosta
PR-URL: #39611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d87fcf9 - Browse repository at this point
Copy the full SHA d87fcf9View commit details -
meta: consolidate emails for tadhgcreedon
PR-URL: #39611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fc9c680 - Browse repository at this point
Copy the full SHA fc9c680View commit details -
Remove unnecessary name specificity in mailmap entries. AUTHORS is unchanged after running update-authors.js with these changes. PR-URL: #39612 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 60f41c3 - Browse repository at this point
Copy the full SHA 60f41c3View commit details -
inspector: update inspector_protocol to 8ec18cf
Apply 8ec18cf: "Support STRING16 in the template when converting CBOR map keys" Refs: https://chromium.googlesource.com/deps/inspector_protocol/+/8ec18cf0885bef0b5c2a922c5dc3813cbf63e962 We're over 2 years out of date in the tools/inspector_protocol directory and I have to imagine this will come back to bite us at some point. But I also don't want to do a huge update all at once, so starting with a single commit. I might bundle commits together a bit more if this goes well. PR-URL: #39614 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for ea5f204 - Browse repository at this point
Copy the full SHA ea5f204View commit details -
tools: improve error detection in find-inactive-collaborators
Previously, if the script failed to find a collaborator section in the README file, it would carry on with no results and no error. This detects the problem and throws an error. It is also more robust in that it will still work if the emeriti section ends up getting moved and does not immedaitely follow the collaborator section. PR-URL: #39617 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 78de83c - Browse repository at this point
Copy the full SHA 78de83cView commit details -
node-api: handle pending exception in cb wrapper
fixes: nodejs/node-addon-api#1025 The functionreference test from the node-api tests was reporting a failed v8 check when Node.js was compiled as debug. The failure was because an exception was pending but the C++ wrappers were returning a return value that was invalid. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #39476 Fixes: nodejs/node-addon-api#1025 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2ca12c8 - Browse repository at this point
Copy the full SHA 2ca12c8View commit details -
PR-URL: #39636 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3e8fc49 - Browse repository at this point
Copy the full SHA 3e8fc49View commit details -
Notable changes: - win,tcp: make `uv_close()` work more like unix. - cleanup,win: Remove `_WIN32` guards on threadpool. - more errno mappings and fixes. - higher performance try-writes. - fix string encoding issue of `uv_os_gethostname()` (note: MINGW-W64 upstream is broken on i686 due to https://sourceforge.net/p/mingw-w64/bugs/899/). - zOS support. - Workarounds for a `copy_file_range()` kernel bug. - Better support for TSan. - darwin: use `RLIMIT_STACK` for fsevents pthread. - fix a bug that would cause libuv to hang if the user called `uv_shutdown()`. - darwin: fix `uv_barrier()` race condition. PR-URL: #39525 Fixes: #39502 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 42359ab - Browse repository at this point
Copy the full SHA 42359abView commit details -
inspector: update inspector_protocol to 89c4adf
Apply a366321, 37518ac, and 89c4adf to tools/inspector_protocol. Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39650 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cf59e87 - Browse repository at this point
Copy the full SHA cf59e87View commit details -
The `state` argument was unused. PR-URL: #39645 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for de17117 - Browse repository at this point
Copy the full SHA de17117View commit details -
test: use template to concatenate string
PR-URL: #39621 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 779417f - Browse repository at this point
Copy the full SHA 779417fView commit details -
doc: fix color contrast issue in light mode
There is a color contrast issue with links in light mode on the API highlight background. This only appears in modules.md. This change fixes it without introducing other contrast issues in either light or dark mode. Previously, the color contrast for some text on modules.html was failing WCAG AA in light mode. PR-URL: #39660 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Configuration menu - View commit details
-
Copy full SHA for 9672bbf - Browse repository at this point
Copy the full SHA 9672bbfView commit details -
doc: update debugger.md description and examples
The console captures in debugger.md are out of date, showing the wrapper: function (exports, require, module, __filename, __dirname) { That wrapper is no longer shown in debug sessions. This also shortens and simplifies the description of the debugger in the lede. PR-URL: #39661 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for df1e20a - Browse repository at this point
Copy the full SHA df1e20aView commit details -
tools: update inspector_protocol to fe0467fd105a
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ad39687 - Browse repository at this point
Copy the full SHA ad39687View commit details -
tools: update inspector_protocol to a53e96d31a2755eb16ca37
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b95a759 - Browse repository at this point
Copy the full SHA b95a759View commit details -
Revert "tools: fix compiler warning in inspector_protocol"
This reverts commit ffb34b6. PR-URL: #39694 Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 383fa01 - Browse repository at this point
Copy the full SHA 383fa01View commit details -
tools: update inspector_protocol to 97d3146
To apply the diff cleanly, ffb34b6 had to be reverted. Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6870bb7 - Browse repository at this point
Copy the full SHA 6870bb7View commit details -
tools: update inspector_protocol to 39ca567
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9847d58 - Browse repository at this point
Copy the full SHA 9847d58View commit details -
tools: update inspector_protocol to e8ba1a7
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 26a067e - Browse repository at this point
Copy the full SHA 26a067eView commit details -
meta: consolidate email addresses for szmarczak
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4301e25 - Browse repository at this point
Copy the full SHA 4301e25View commit details -
meta: consolidate email addresses for tadjik1
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 12fe34e - Browse repository at this point
Copy the full SHA 12fe34eView commit details -
meta: consolidate email addresses for MarshallOfSound
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bb06282 - Browse repository at this point
Copy the full SHA bb06282View commit details -
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cd67d86 - Browse repository at this point
Copy the full SHA cd67d86View commit details -
meta: consolidate AUTHORS entries for samshull
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1eda844 - Browse repository at this point
Copy the full SHA 1eda844View commit details -
meta: consolidate AUTHORS entries for robin-drexler
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e86b59c - Browse repository at this point
Copy the full SHA e86b59cView commit details -
meta: consolidate AUTHORS entries for Ayase-252
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b65a635 - Browse repository at this point
Copy the full SHA b65a635View commit details -
meta: consolidate AUTHORS entries for homosaur
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6916a6c - Browse repository at this point
Copy the full SHA 6916a6cView commit details -
meta: consolidate AUTHORS entries for ooHmartY
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4b2eee5 - Browse repository at this point
Copy the full SHA 4b2eee5View commit details -
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: #39595 PR-URL: #39605 Refs: #39595 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5b11042 - Browse repository at this point
Copy the full SHA 5b11042View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c33e4b - Browse repository at this point
Copy the full SHA 9c33e4bView commit details -
Used more validators for the sake of consistency. PR-URL: #39663 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dbaf498 - Browse repository at this point
Copy the full SHA dbaf498View commit details -
doc: fixed variable names in queueMicrotask example
fixed variable name in queueMicrotask where url variable was used instead of key PR-URL: #39634 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 53300d3 - Browse repository at this point
Copy the full SHA 53300d3View commit details -
Original commit message: tools: fix compiler warning in inspector_protocol error: comparison of integer expressions of different signedness: ‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Werror=sign-compare] 2562 | if (!success || std::numeric_limits<int32_t>::max() < | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ 2563 | token_start_internal_value_) { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ PR-URL: #37573 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> PR-URL: #39725 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 09630cf - Browse repository at this point
Copy the full SHA 09630cfView commit details -
tools: fix more build warnings in inspector_protocol
PR-URL: #39725 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a338c0e - Browse repository at this point
Copy the full SHA a338c0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49a7962 - Browse repository at this point
Copy the full SHA 49a7962View commit details -
Used the `validateInteger()` validator to cleanup validation and keep consistency. PR-URL: #39652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e101935 - Browse repository at this point
Copy the full SHA e101935View commit details -
tools: update path-parse in markdown linter package-lock file
Refs: GHSA-hj48-42vr-x3v9 PR-URL: #39729 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for f8fee44 - Browse repository at this point
Copy the full SHA f8fee44View commit details -
src: fix TextDecoder final flush size calculation
Flushing a TextDecoder with a zero-sized input and pending incomplete characters was failing when fatal: false. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39737 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c4686fa - Browse repository at this point
Copy the full SHA c4686faView commit details -
doc: fix YAML comment opening tags
Several YAML documentation comments incorrectly started with `<!--YAML` instead of `<!-- YAML`, resulting in their content missing in the rendered documentation. PR-URL: #38324 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 95b9cc7 - Browse repository at this point
Copy the full SHA 95b9cc7View commit details -
tools: update markdown linter rules
Update remark-preset-lint-node to 2.2.0 which includes improved YAML comment linting for our markdown files. PR-URL: #38384 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dfdf6c7 - Browse repository at this point
Copy the full SHA dfdf6c7View commit details -
tools: bump remark-preset-lint-node to 3.0.0
PR-URL: #39755 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for de94611 - Browse repository at this point
Copy the full SHA de94611View commit details -
Some of the validators can be simplified by removing unnecessary object parameters and using validators in another validators to keep consistency. PR-URL: #39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 338189f - Browse repository at this point
Copy the full SHA 338189fView commit details -
dgram: use simplified validator
The `dgram` lib module should use the simplified `validatePort()` validator. PR-URL: #39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e201293 - Browse repository at this point
Copy the full SHA e201293View commit details -
The validators test should use the simplified `validateArray()` validator. PR-URL: #39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e660892 - Browse repository at this point
Copy the full SHA e660892View commit details -
policy: fix integrity when DEFAULT_ENCODING is set
PR-URL: #39750 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0ff520c - Browse repository at this point
Copy the full SHA 0ff520cView commit details -
doc: add himadriganguly as a triager
I would like to apply for the role of a triager in this project. My motivation to become a triager is to help manage issues, as well as learn deeper concepts of Node.js, and eventually become a collaborator! I hereby declare that I have read and understood the Code of Conduct and will adhere to that. PR-URL: #39757 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 00f2cee - Browse repository at this point
Copy the full SHA 00f2ceeView commit details -
doc: add example of self-reference in scoped packages
PR-URL: #37630 Fixes: #37618 Refs: #37618 (comment) Co-authored-by: Michaël Zasso <targos@protonmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2624c98 - Browse repository at this point
Copy the full SHA 2624c98View commit details -
tools: update markdown lint dependencies
PR-URL: #39770 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 64714b4 - Browse repository at this point
Copy the full SHA 64714b4View commit details -
doc: fix lint errors in packages.md
Code samples that use CJS-only syntax need to use the cjs markdown identifiers. PR-URL: #39792 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Configuration menu - View commit details
-
Copy full SHA for 9e772ca - Browse repository at this point
Copy the full SHA 9e772caView commit details -
doc: fix malformed changelog entries
PR-URL: #39791 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 1a8a26d - Browse repository at this point
Copy the full SHA 1a8a26dView commit details -
build: add option to hide console window
Adds a Environment flag to allow embedders to set CREATE_NO_WINDOW property when spawning processes, which is useful for GUI programs that do not want to show console windows when running terminal commands. PR-URL: #39712 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ed3c332 - Browse repository at this point
Copy the full SHA ed3c332View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37b4708 - Browse repository at this point
Copy the full SHA 37b4708View commit details -
esm: use correct URL for error decoration
PR-URL: #37854 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d42bbe4 - Browse repository at this point
Copy the full SHA d42bbe4View commit details -
policy: canonicalize before resolving specifiers
PR-URL: #37863 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bcb85ad - Browse repository at this point
Copy the full SHA bcb85adView commit details -
tools: update rollup to latest version in markdown linter
PR-URL: #39797 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 67c5921 - Browse repository at this point
Copy the full SHA 67c5921View commit details -
meta: add gyp as owner of gyp files and tools/gyp
Co-authored-by: Jiawen Geng <technicalcute@gmail.com> PR-URL: #34847 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8f8f528 - Browse repository at this point
Copy the full SHA 8f8f528View commit details -
tools: update markdown linter dependencies and move to ESM
PR-URL: #39801 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 67f1bff - Browse repository at this point
Copy the full SHA 67f1bffView commit details -
This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing. PR-URL: #39832 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e9b1a00 - Browse repository at this point
Copy the full SHA e9b1a00View commit details -
doc: update instructions for cc
- update intructions on adding cc for email to nodejs-sec mailing list as UI does not allow it to be done directly. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #39674 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 615477f - Browse repository at this point
Copy the full SHA 615477fView commit details -
deps: V8: cherry-pick 00bb1a77c03e
Original commit message: [date] Fix Date#getMinutes() test failures After building V8 using Clang (./out/x64.release/v8_build_config.json says that "is_clang" is true), I could reproduce the referenced bug report locally. Replacing the getMinutes() calls with getUTCMinutes() calls fixed the test failure. Signed-off-by: Darshan Sen <raisinten@gmail.com> Bug: v8:11200 Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#76367} Refs: v8/v8@00bb1a7 Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #39829 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 34c0701 - Browse repository at this point
Copy the full SHA 34c0701View commit details -
doc: improve description of the triagers team
PR-URL: #39833 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7b123ec - Browse repository at this point
Copy the full SHA 7b123ecView commit details -
PR-URL: #35831 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5e1cba8 - Browse repository at this point
Copy the full SHA 5e1cba8View commit details -
doc: add duplicate CVE check in sec. release doc
This commit adds a note about only creating a CVE for Node.js vulnerabilities. The motivation for this is a recent HackerOne report where I created a CVE for a c-ares issue. This CVE should have been created by the c-ares project, and it was later, but we never updated our HackerOne report to use their CVE number. Hopefully this extra note in the release doc will help us check for this situaion and avoid this in the future. PR-URL: #39845 Refs: https://hackerone.com/reports/1178337 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8efd559 - Browse repository at this point
Copy the full SHA 8efd559View commit details -
build: fix update authors commit
Refs: #39855 (comment) PR-URL: #39858 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d99deea - Browse repository at this point
Copy the full SHA d99deeaView commit details -
tools: use find-inactive-collaborators to modify README.md
Update find-inactive-collaborators to move inactive collaborators to the emeriti section of README.md. PR-URL: #39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 417a3ac - Browse repository at this point
Copy the full SHA 417a3acView commit details -
tools: update workflow to open a pull request
Now that find-inactive-collaborators.mjs automates the README.md changes to move the inactive collaborators to the emeriti section, update the GitHub Actions workflow to open a pull request. PR-URL: #39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 55493f2 - Browse repository at this point
Copy the full SHA 55493f2View commit details
Commits on Sep 7, 2021
-
tools: make utils.SearchFiles Python2-compatible
PR-URL: #40020 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for d39200c - Browse repository at this point
Copy the full SHA d39200cView commit details -
test: fix flaky test-child-process-exec-abortcontroller-promisified
Configuration menu - View commit details
-
Copy full SHA for 64fb928 - Browse repository at this point
Copy the full SHA 64fb928View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fabd8e - Browse repository at this point
Copy the full SHA 0fabd8eView commit details -
test: fix test-vm-memleak for high baseline platforms
test-vm-memleak always fails on AIX in CI because the test checks that total memory consumption is less than 64 Mb, but AIX uses over 100 Mb just as a baseline. So instead, let's compare the memory consumption to the baseline and make sure it is within 32 Mb. PR-URL: #38062 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 007f9a0 - Browse repository at this point
Copy the full SHA 007f9a0View commit details -
fs: improve fsPromises writeFile performance
Increase the write chunk size in fsPromises writeFile to improve performance. PR-URL: #37610 Backport-PR-URL: #39993 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d2834fb - Browse repository at this point
Copy the full SHA d2834fbView commit details -
2021-09-28, Version 14.18.0 'Fermium' (LTS)
Notable changes: assert: * change status of legacy asserts (James M Snell) #38113 buffer: * (SEMVER-MINOR) introduce Blob (James M Snell) #36811 * (SEMVER-MINOR) add base64url encoding option (Filip Skokan) #36952 child_process: * (SEMVER-MINOR) allow `options.cwd` receive a URL (Khaidi Chu) #38862 * (SEMVER-MINOR) add timeout to spawn and fork (Nitzan Uziely) #37256 * (SEMVER-MINOR) allow promisified exec to be cancel (Carlos Fuentes) #34249 * (SEMVER-MINOR) add 'overlapped' stdio flag (Thiago Padilha) #29412 cli: * (SEMVER-MINOR) add -C alias for --conditions flag (Guy Bedford) #38755 * (SEMVER-MINOR) add --node-memory-debug option (Anna Henningsen) #35537 dns: * (SEMVER-MINOR) add "tries" option to Resolve options (Luan Devecchi) #39610 * (SEMVER-MINOR) allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) #38099 doc: * (SEMVER-MINOR) add missing change to resolver ctor (Luan Devecchi) #39610 * refactor fs docs structure (James M Snell) #37170 errors: * (SEMVER-MINOR) remove experimental from --enable-source-maps (Benjamin Coe) #37362 esm: * deprecate legacy main lookup for modules (Guy Bedford) #36918 fs: * (SEMVER-MINOR) allow empty string for temp directory prefix (Voltrex) #39028 * (SEMVER-MINOR) allow no-params fsPromises fileHandle read (Nitzan Uziely) #38287 * (SEMVER-MINOR) add support for async iterators to `fsPromises.writeFile` (HiroyukiYagihashi) #37490 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * (SEMVER-MINOR) add fsPromises.watch() (James M Snell) #37179 * (SEMVER-MINOR) allow `position` parameter to be a `BigInt` in read and readSync (Darshan Sen) #36190 http2: * (SEMVER-MINOR) add support for sensitive headers (Anna Henningsen) #34145 * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) #35978 inspector: * mark as stable (Gireesh Punathil) #37748 module: * (SEMVER-MINOR) add support for `URL` to `import.meta.resolve` (Antoine du Hamel) #38587 * (SEMVER-MINOR) add support for `node:`‑prefixed `require(…)` calls (ExE Boss) #37246 net: * (SEMVER-MINOR) introduce net.BlockList (James M Snell) #34625 node-api: * (SEMVER-MINOR) allow retrieval of add-on file name (Gabriel Schulhof) #37195 os: * (SEMVER-MINOR) add os.devNull (Luigi Pinca) #38569 perf_hooks: * (SEMVER-MINOR) introduce createHistogram (James M Snell) #37155 process: * (SEMVER-MINOR) add api to enable source-maps programmatically (legendecas) #39085 * (SEMVER-MINOR) add `'worker'` event (James M Snell) #38659 * (SEMVER-MINOR) add direct access to rss without iterating pages (Adrien Maret) #34291 readline: * (SEMVER-MINOR) add AbortSignal support to interface (Nitzan Uziely) #37932 * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676 * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662 repl: * (SEMVER-MINOR) add auto‑completion for `node:`‑prefixed `require(…)` calls (ExE Boss) #37246 src: * (SEMVER-MINOR) call overload ctor from the original ctor (Darshan Sen) #39768 * (SEMVER-MINOR) add a constructor overload for CallbackScope (Darshan Sen) #39768 * (SEMVER-MINOR) allow to negate boolean CLI flags (Michaël Zasso) #39023 * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010 * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441 * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447 * (SEMVER-MINOR) add maybe versions of EmitExit and EmitBeforeExit (Anna Henningsen) #35486 stream: * (SEMVER-MINOR) add readableDidRead if has been read from (Robert Nagy) #39589 * (SEMVER-MINOR) pipeline accept Buffer as a valid first argument (Nitzan Uziely) #37739 tls: * (SEMVER-MINOR) allow reading data into a static buffer (Andrey Pechkurov) #35753 tools: * (SEMVER-MINOR) add `Worker` to type-parser (James M Snell) #38659 url: * (SEMVER-MINOR) expose urlToHttpOptions utility (Yongsheng Zhang) #35960 util: * (SEMVER-MINOR) expose toUSVString (Robert Nagy) #39814 v8: * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807 * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807 worker: * (SEMVER-MINOR) add setEnvironmentData/getEnvironmentData (James M Snell) #37486 PR-URL: #39990
Configuration menu - View commit details
-
Copy full SHA for 7af8896 - Browse repository at this point
Copy the full SHA 7af8896View commit details