Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update HdrHistogram? #39450

Closed
targos opened this issue Jul 19, 2021 · 1 comment
Closed

update HdrHistogram? #39450

targos opened this issue Jul 19, 2021 · 1 comment
Labels
dependencies Pull requests that update a dependency file.

Comments

@targos
Copy link
Member

targos commented Jul 19, 2021

HdrHistogram was last updated more than two years ago: https://github.com/nodejs/node/tree/master/deps/histogram/src
Should we update it? The upstream repository has some activity and had an official release in 2020: https://github.com/HdrHistogram/HdrHistogram_c/releases/tag/0.11.2

/cc @mcollina @jasnell
@targos targos added the dependencies Pull requests that update a dependency file. label Jul 19, 2021
mcollina added a commit to mcollina/node that referenced this issue Jul 20, 2021
@mcollina
deps: bump HdrHistogram_C to 0.11.2
2a0ee46 
Release tag: https://github.com/HdrHistogram/HdrHistogram_c/releases/tag/0.11.2
Fixes: nodejs#39450
@mcollina mcollina mentioned this issue Jul 20, 2021
Closed
@mcollina
Copy link
Member

PR in #39462

targos pushed a commit that referenced this issue Jul 25, 2021
@mcollina @targos
deps: bump HdrHistogram_C to 0.11.2
b6d9336 
Release tag: https://github.com/HdrHistogram/HdrHistogram_c/releases/tag/0.11.2
Fixes: #39450

PR-URL: #39462
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
richardlau pushed a commit that referenced this issue Jul 29, 2021
@mcollina @richardlau
deps: bump HdrHistogram_C to 0.11.2
44dba09 
Release tag: https://github.com/HdrHistogram/HdrHistogram_c/releases/tag/0.11.2
Fixes: #39450

PR-URL: #39462
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this issue Jul 29, 2021
@mcollina @BethGriggs
deps: bump HdrHistogram_C to 0.11.2
89796d0 
Release tag: https://github.com/HdrHistogram/HdrHistogram_c/releases/tag/0.11.2
Fixes: #39450

PR-URL: #39462
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this issue Sep 4, 2021
@mcollina @targos
deps: bump HdrHistogram_C to 0.11.2
d863a9d 
Release tag: https://github.com/HdrHistogram/HdrHistogram_c/releases/tag/0.11.2
Fixes: #39450

PR-URL: #39462
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: bump HdrHistogram_C to 0.11.2 mcollina/node
2 participants
@mcollina @targos