Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: upgrade highlight.js to version 11.0.1 #39032

Closed
wants to merge 2 commits into from
Closed

tools: upgrade highlight.js to version 11.0.1 #39032

wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 14, 2021

It seems our tooling is not affected by any of the breaking changes highlight.js v11, I think there's no reason to keep using v10.x.

Refs: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md

@aduh95 aduh95 requested a review from targos June 14, 2021 15:50
@github-actions github-actions bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jun 14, 2021
@targos
Copy link
Member

targos commented Jun 14, 2021

Did you make a diff of the out/doc directory between master and this?

When I looked at the breaking changes, it seemed we would be affected by the removal of coffeescript highlighting,

@aduh95
Copy link
Contributor Author

aduh95 commented Jun 14, 2021 •
edited
Loading

CoffeeScript is removed from highlight.min.js (so the browser build, not the CommonJS one). I can confirm it's still in the npm package, and that all coffee code snippets are still highlighted.

@targos
Copy link
Member

targos commented Jun 14, 2021

Diff: https://gist.github.com/targos/277095031d5461875474ca4b292bf989

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 26, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2021
@github-actions
Copy link
Contributor

Landed in 1317252...fdb097c

@github-actions github-actions bot closed this Jun 26, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jun 26, 2021
@aduh95 @nodejs-github-bot
tools: upgrade highlight.js to version 11.0.1
fdb097c 
Refs: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md

PR-URL: #39032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 deleted the hljs11 branch June 26, 2021 15:18
targos pushed a commit that referenced this pull request Jul 11, 2021
@aduh95 @targos
tools: upgrade highlight.js to version 11.0.1
4715105 
Refs: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md

PR-URL: #39032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 13, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@aduh95 @targos
tools: upgrade highlight.js to version 11.0.1
70e527c 
Refs: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md

PR-URL: #39032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduh95 @targos @lpinca