tools: add multiple locations support in license builder

[legendecas]

Refs: #39360

[legendecas]

@aduh95 hi, since you edited this file recently, may I have your review on this PR? Many thanks!

[richardlau]

I missed whatever PR added it but I'd prefer we didn't have duplication in the repository... I'm a bit surprised that gtest is in src.

Even if we allow for the duplication, we should do basic checks that the licenses in each location are actually the same.

[legendecas]

@richardlau the reason that we split a part of gtest into src is that the only file in src/gtest is a header only gtest_prod.h and it contains no actual code generation but only class friendship declaration (for cctest).

Do you suggest we should check the LICENSE files src/gtest/LICENSE and test/cctest/gtest/LICENSE in tools/license-builder.sh?

[targos]

There's also a copy of gtest_prod.h in deps/v8. Could we use it?

[legendecas]

@targos There's also a copy of gtest_prod.h in deps/v8. Could we use it?

It can work. But that would cause indirect dependencies IIUC. There's also a copy of zlib in deps/v8 yet we use the copy in deps/zlib instead.

[targos]

@legendecas good point. Then could we put the file in test/cctest/gtest/gtest_prod.h instead of src?

[legendecas]

@targos only header gtest_prod.h can be referenced in src. Other header files located in test/cctest/gtest should not be referenced in src as they include testing implementations. Though I don't think it is a good idea to referencing test/* headers from src. Or we can move all of them to deps/googletest so that we don't need two separate places for gtest.

[targos]

we can move all of them to deps/googletest so that we don't need two separate places for gtest.

SGTM

[legendecas]

closed in favor of #39386