tools: use find-inactive-collaborators to edit README and open pull request#39825
Closed
Trott wants to merge 2 commits intonodejs:masterfrom
Closed
tools: use find-inactive-collaborators to edit README and open pull request#39825Trott wants to merge 2 commits intonodejs:masterfrom
Trott wants to merge 2 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
Member
Author
|
I ran this on my fork so I could see what the pull request would look like. https://github.com/Trott/io.js/pull/4/files |
aduh95
approved these changes
Aug 21, 2021
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Non-blocking suggestion: I haven't tested it, but could we use an async generator here instead?
Update find-inactive-collaborators to move inactive collaborators to the emeriti section of README.md.
Now that find-inactive-collaborators.mjs automates the README.md changes to move the inactive collaborators to the emeriti section, update the GitHub Actions workflow to open a pull request.
Member
Author
Thanks for the suggestion. I think it's more clear/obvious when reading the code if we use the synchronous function so I'm inclined to leave it as is, or at least save the suggested change for a subsequent pull request where just it can be discussed. Since you labeled the suggestion |
jasnell
approved these changes
Aug 24, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 0d88c14...cee024a |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2021
Update find-inactive-collaborators to move inactive collaborators to the emeriti section of README.md. PR-URL: #39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2021
Now that find-inactive-collaborators.mjs automates the README.md changes to move the inactive collaborators to the emeriti section, update the GitHub Actions workflow to open a pull request. PR-URL: #39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 25, 2021
Update find-inactive-collaborators to move inactive collaborators to the emeriti section of README.md. PR-URL: #39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 25, 2021
Now that find-inactive-collaborators.mjs automates the README.md changes to move the inactive collaborators to the emeriti section, update the GitHub Actions workflow to open a pull request. PR-URL: #39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Update find-inactive-collaborators to move inactive collaborators to the emeriti section of README.md. PR-URL: #39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Now that find-inactive-collaborators.mjs automates the README.md changes to move the inactive collaborators to the emeriti section, update the GitHub Actions workflow to open a pull request. PR-URL: #39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.