Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: use find-inactive-collaborators to edit README and open pull request #39825

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 21, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 21, 2021
@Trott
Copy link
Member Author

Trott commented Aug 21, 2021

I ran this on my fork so I could see what the pull request would look like. https://github.com/Trott/io.js/pull/4/files

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking suggestion: I haven't tested it, but could we use an async generator here instead?

tools/find-inactive-collaborators.mjs Show resolved Hide resolved
tools/find-inactive-collaborators.mjs Show resolved Hide resolved
tools/find-inactive-collaborators.mjs Show resolved Hide resolved
tools/find-inactive-collaborators.mjs Show resolved Hide resolved
tools/find-inactive-collaborators.mjs Show resolved Hide resolved
tools/find-inactive-collaborators.mjs Show resolved Hide resolved
tools/find-inactive-collaborators.mjs Show resolved Hide resolved
tools/find-inactive-collaborators.mjs Show resolved Hide resolved
tools/find-inactive-collaborators.mjs Show resolved Hide resolved
tools/find-inactive-collaborators.mjs Show resolved Hide resolved
Update find-inactive-collaborators to move inactive collaborators to the
emeriti section of README.md.
Now that find-inactive-collaborators.mjs automates the README.md changes
to move the inactive collaborators to the emeriti section, update the
GitHub Actions workflow to open a pull request.
@Trott
Copy link
Member Author

Trott commented Aug 24, 2021

Non-blocking suggestion: I haven't tested it, but could we use an async generator here instead?

Thanks for the suggestion. I think it's more clear/obvious when reading the code if we use the synchronous function so I'm inclined to leave it as is, or at least save the suggested change for a subsequent pull request where just it can be discussed. Since you labeled the suggestion non-blocking, I'm going to mark it as resolved. Hope that's OK.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2021
@github-actions
Copy link
Contributor

Landed in 0d88c14...cee024a

@github-actions github-actions bot closed this Aug 25, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 25, 2021
Update find-inactive-collaborators to move inactive collaborators to the
emeriti section of README.md.

PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Aug 25, 2021
Now that find-inactive-collaborators.mjs automates the README.md changes
to move the inactive collaborators to the emeriti section, update the
GitHub Actions workflow to open a pull request.

PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Aug 25, 2021
Update find-inactive-collaborators to move inactive collaborators to the
emeriti section of README.md.

PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Aug 25, 2021
Now that find-inactive-collaborators.mjs automates the README.md changes
to move the inactive collaborators to the emeriti section, update the
GitHub Actions workflow to open a pull request.

PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Update find-inactive-collaborators to move inactive collaborators to the
emeriti section of README.md.

PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Now that find-inactive-collaborators.mjs automates the README.md changes
to move the inactive collaborators to the emeriti section, update the
GitHub Actions workflow to open a pull request.

PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the update-process branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants